Subject: Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
To: arm@kernel.org, olof@lixom.net, arnd@arndb.de
References: <1459245786-11905-1-git-send-email-suzuki.poulose@arm.com>
 <5704D13E.6060701@arm.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
Message-ID: <57066C38.6000902@arm.com>
Date: Thu, 7 Apr 2016 15:18:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <5704D13E.6060701@arm.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 34

On 06/04/16 10:05, Andre Przywara wrote:
> Hi,
>
> On 29/03/16 11:03, Suzuki K Poulose wrote:
>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>> added support for ARCH_SUNXI on arm64, but failed to select
>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>> and causes build failures like :
>
> Thanks for the catch! GENERIC_IRQ_CHIP somehow gets selected by
> defconfig, so I didn't see the issue.
>
> Currently we don't need the irq-sunxi-nmi driver, but we may in the
> future and it depends on CONFIG_ARCH_SUNXI only, so I guess this patch
> is the easiest solution (rather than creating a separate config symbol
> for it, which may be an option for later).

...

>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
>> Cc: Andre Przywara <andre.przywara@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Acked-by: Andre Przywara <andre.przywara@arm.com>


Olof, Arnd,

Please could you pick this for rc3 ?

Thanks
Suzuki