Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756735AbcDGPON (ORCPT ); Thu, 7 Apr 2016 11:14:13 -0400 Received: from www.linutronix.de ([62.245.132.108]:48315 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756710AbcDGPOD (ORCPT ); Thu, 7 Apr 2016 11:14:03 -0400 Subject: Re: [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() To: Heiko Carstens References: <1459765640-13599-1-git-send-email-anna-maria@linutronix.de> <20160405104912.GC3937@osiris> <57039DC2.6090907@linutronix.de> <20160405112336.GB6890@osiris> <20160405113637.GC6890@osiris> <20160405115129.GE30124@linutronix.de> <5703A836.7030708@linutronix.de> <20160405121155.GF6890@osiris> <20160405155904.GA19022@linutronix.de> <20160406195133.GB3485@osiris> Cc: Thomas Gleixner , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, rt@linutronix.de, Martin Schwidefsky , Anna-Maria Gleixner From: Sebastian Andrzej Siewior Message-ID: <57067938.6030908@linutronix.de> Date: Thu, 7 Apr 2016 17:14:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160406195133.GB3485@osiris> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 478 Lines: 13 On 04/06/2016 09:51 PM, Heiko Carstens wrote: > This fixes the issue that a second cpu_down() will take forever, if > __cpu_disable() fails. Yes. But even without the second take down your CPU isn't complete up. > However it does not fix the issue that CPU_DOWN_FAILED will be seen on a > different cpu than the cpu that was supposed to be taken offline. This is correct. It fixes only the regression you reported. The CPU_DOWN_FAILED patches are on hold for now. Sebastian