Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756691AbcDGPtw (ORCPT ); Thu, 7 Apr 2016 11:49:52 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:36779 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756544AbcDGPtu (ORCPT ); Thu, 7 Apr 2016 11:49:50 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: stefanb@linux.vnet.ibm.com X-IBM-RcptTo: linux-api@vger.kernel.org;linux-doc@vger.kernel.org;linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Subject: Re: [PATCH v9 2/4] tpm: Proxy driver for supporting multiple emulated TPMs To: Jarkko Sakkinen References: <1459275554-12915-1-git-send-email-stefanb@linux.vnet.ibm.com> <1459275554-12915-3-git-send-email-stefanb@linux.vnet.ibm.com> <20160407123539.GA17489@intel.com> Cc: tpmdd-devel@lists.sourceforge.net, jgunthorpe@obsidianresearch.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-api@vger.kernel.org From: Stefan Berger Message-ID: <57068198.6050407@linux.vnet.ibm.com> Date: Thu, 7 Apr 2016 11:49:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160407123539.GA17489@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040715-0009-0000-0000-00001AAF80BD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1207 Lines: 25 On 04/07/2016 08:35 AM, Jarkko Sakkinen wrote: > On Tue, Mar 29, 2016 at 02:19:12PM -0400, Stefan Berger wrote: >> This patch implements a proxy driver for supporting multiple emulated TPMs >> in a system. >> >> The driver implements a device /dev/vtpmx that is used to created >> a client device pair /dev/tpmX (e.g., /dev/tpm10) and a server side that >> is accessed using a file descriptor returned by an ioctl. >> The device /dev/tpmX is the usual TPM device created by the core TPM >> driver. Applications or kernel subsystems can send TPM commands to it >> and the corresponding server-side file descriptor receives these >> commands and delivers them to an emulated TPM. >> >> Signed-off-by: Stefan Berger >> CC: linux-kernel@vger.kernel.org >> CC: linux-doc@vger.kernel.org >> CC: linux-api@vger.kernel.org > Reviewed-by: Jarkko Sakkinen > Tested-by: Jarkko Sakkinen Thanks. So I can post a v10 where I have to re-introduce the priv field but put it into the tpm_chip struct. Obviously it needs this field. I am not sure whether you'll let me take the Reviewed-by and Tested-by, though? Stefan