Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757003AbcDGQyG (ORCPT ); Thu, 7 Apr 2016 12:54:06 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36543 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756969AbcDGQyE (ORCPT ); Thu, 7 Apr 2016 12:54:04 -0400 Date: Thu, 7 Apr 2016 17:53:55 +0100 From: Daniel Lezcano To: rcochran@linutronix.de Cc: "Brown, Len" , "Gortmaker, Paul (Wind River)" , "linux-kernel@vger.kernel.org" , Len Brown , "linux-pm@vger.kernel.org" Subject: Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular Message-ID: <20160407165355.GA9188@linaro.org> References: <1459099777-4962-1-git-send-email-paul.gortmaker@windriver.com> <20160404195535.GQ1778@windriver.com> <20160405031152.GA22836@linutronix.de> <1A7043D5F58CCB44A599DFD55ED4C94846A1C854@fmsmsx115.amr.corp.intel.com> <20160405043017.GA24357@linutronix.de> <1A7043D5F58CCB44A599DFD55ED4C94846A1CD40@fmsmsx115.amr.corp.intel.com> <20160405073312.GA30124@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160405073312.GA30124@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 32 On Tue, Apr 05, 2016 at 09:33:12AM +0200, rcochran@linutronix.de wrote: > On Tue, Apr 05, 2016 at 05:53:47AM +0000, Brown, Len wrote: > > > On Tue, Apr 05, 2016 at 04:20:47AM +0000, Brown, Len wrote: > > > > No, I do not believe that cpuidle should bother > > > > supporting changing idle drivers at run-time. > > > > > > Huh? But you just said, "it would be good to be able to unload it > > > when it doesn't probe." > > > > being able to switch the registered driver at run-time > > does not require the driver to be modular. > > Uh, right, but you don't think that the cpuidle core should allow > changing drivers. If it doesn't allowing changing drivers, then there > would be just one choice, compiled in, and thus none of the drivers > should be modular. Actually, the modular support has been removed from almost all the cpuidle drivers and the cpuidle framework is no longer assuming driver could be unloaded. The cpuidle drivers are very arch/platform specific and the acpi vs something is an exception and could be handled differently than converting to modular again. I don't see the point on removing a cpuidle driver at runtime to something else. Removing the modular dead code in the driver makes sense as this what have been done in the others drivers. -- Daniel