Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932211AbcDGRC7 (ORCPT ); Thu, 7 Apr 2016 13:02:59 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51088 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932149AbcDGRC6 (ORCPT ); Thu, 7 Apr 2016 13:02:58 -0400 Date: Thu, 7 Apr 2016 10:02:49 -0700 From: Mark Brown To: Martin Fuzzey Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org Message-ID: <20160407170249.GV1924@sirena.org.uk> References: <57065FB5.6040707@parkeon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vKcNkqnJHUUp475E" Content-Disposition: inline In-Reply-To: <57065FB5.6040707@parkeon.com> X-Cookie: Even bytes get lonely for a little bit. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 209.65.105.133 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: Regulator: drivers that need to know their supply X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1179 Lines: 32 --vKcNkqnJHUUp475E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 07, 2016 at 03:25:09PM +0200, Martin Fuzzey wrote: > To implement the .enable_time() method I need the voltage (which is > the supply's voltage). No, this is not sensible. You should be telling the framework about the slew rate and letting the framework work out how long it's going to take to transition. Your driver shouldn't be peering around inside other regulators, it should be telling the framework what it does itself and any handling of interrelationships should be in the framework. --vKcNkqnJHUUp475E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXBpK4AAoJECTWi3JdVIfQWG8IAIToxNmgIcPckpYJUIvdJUCI YKjSjxM3P82tNVr6FdSfQSQJGQOMvEkDBZip1+RLdmZ/3qo4VlqIFqnth3dxn68L D1CwH4TL6rJZU2dt4LNqIzPL4NPH91Wy954gENi/26x7tp6QzZTosHhDR0rxKuVM es66KqJnlLRRlegVSCIkrd2HH7azJwzNQGpZ6aW6JVe40e8dl4X93lfcSyzgt6id TkS+OSFaa5m53viQoDSccQpvgfYI6SoXi70Oy6VTu3Sw6OCZvd+/NTkWLf29lcTW Wm38hewr2Wp/d5Vi0RKU3jc5/wI4Fcc3dkjgzfBIJxXFduZfAIwmMK/gLj2XWbQ= =PhZL -----END PGP SIGNATURE----- --vKcNkqnJHUUp475E--