Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757214AbcDGRkf (ORCPT ); Thu, 7 Apr 2016 13:40:35 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:34471 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757183AbcDGRkd (ORCPT ); Thu, 7 Apr 2016 13:40:33 -0400 Date: Thu, 7 Apr 2016 18:40:28 +0100 From: Chris Bainbridge To: Mathias Nyman Cc: gregkh@linuxfoundation.org, johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu Subject: Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of bus Message-ID: <20160407174028.GA14673@localhost> References: <1454939360-7947-1-git-send-email-chris.bainbridge@gmail.com> <56BB6FC2.8090804@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56BB6FC2.8090804@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 18 On Wed, Feb 10, 2016 at 07:13:38PM +0200, Mathias Nyman wrote: > > Most likely xhci is messed up after two device slots are in default state at the same time. > This happens when both threads are in hub_port_init() have called hub_port_reset() > > The issue becomes visible when the the descriptor read and set address both fail after > the port resets. > > xhci specs 4.5.3 has one tiny note about this: > "Note: Software shall not transition more than one Device Slot to the Default State at a time" > > So to me, and from xhci pov this patch looks like the correct solution, > but I might be missing some usb core side details. > > -Mathias > Just following up to see if this patch disappeared into the void?