Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932356AbcDGR5p (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Apr 2016 13:57:45 -0400
Received: from mail.kernel.org ([198.145.29.136]:60397 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932251AbcDGR5m (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Apr 2016 13:57:42 -0400
Date: Thu, 7 Apr 2016 12:57:36 -0500
From: Rob Herring <robh@kernel.org>
To: Sreedhar Sambangi <ssambang@codeaurora.org>
Cc: devicetree@vger.kernel.org, andy.gross@linaro.org,
        linux-arm-msm@vger.kernel.org, david.brown@linaro.org,
        pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        linux@arm.linux.org.uk, linux-soc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        qca-upstream.external@qca.qualcomm.com
Subject: Re: [PATCH 1/2] qcom: ipq4019: Add regulator support to DK04 device
 tree
Message-ID: <20160407175736.GI32257@rob-hp-laptop>
References: <1459804090-31739-1-git-send-email-ssambang@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1459804090-31739-1-git-send-email-ssambang@codeaurora.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1560
Lines: 40

On Mon, Apr 04, 2016 at 02:08:10PM -0700, Sreedhar Sambangi wrote:
>     This adds the regulator nodes to DK04 device tree to support
> 
> Change-Id: I9c1df0e720a330bf6db1889fd2247f6a70ea6faa
> Signed-off-by: Sreedhar Sambangi <ssambang@codeaurora.org>
> ---
>  .../bindings/regulator/ipq4019-regulator.txt          | 19 +++++++++++++++++++
>  arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi         | 11 +++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> 
> diff --git a/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt b/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> new file mode 100644
> index 0000000..9d934a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> @@ -0,0 +1,19 @@
> +* Qualcomm Technologies, Inc. IPQ4019 regulators
> +
> +Required properties:
> +- compatible		: Must be "regulator-ipq4019".

Doesn't match your example which correctly has vendor prefix. Also, the 
preferred form is <vendor>,<soc>-<block>.

> +- states		: Selection of available voltages and corresponding values

Too generic of a name.

Is this not fixed by the h/w block?

> +- reg			: Register address for controlling LDO
> +- mask			: Mask value for switching voltages

What else is in this register? If something unrelated, then this is all 
wrong to the regulator. You can only define the register address in one 
place in the DT. Otherwise, you should know the mask from the compatible 
string.

Rob