Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932399AbcDGR6K (ORCPT ); Thu, 7 Apr 2016 13:58:10 -0400 Received: from mail.kernel.org ([198.145.29.136]:60582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757091AbcDGR6H (ORCPT ); Thu, 7 Apr 2016 13:58:07 -0400 Date: Thu, 7 Apr 2016 12:57:52 -0500 From: Rob Herring To: Stanimir Varbanov Cc: Mark Rutland , Vinod Koul , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Sinan Kaya , Pramod Gurav Subject: Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property Message-ID: <20160407175752.GM32257@rob-hp-laptop> References: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> <1459896982-30171-4-git-send-email-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459896982-30171-4-git-send-email-stanimir.varbanov@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 24 On Wed, Apr 06, 2016 at 01:56:20AM +0300, Stanimir Varbanov wrote: > Some of the peripherals has bam which is controlled by remote > processor, thus the bam dma driver must avoid register writes > which initialise bam hw block. Those registers are protected > from xPU block and any writes to them will lead to secure > violation and system reboot. > > Adding the contolled_remotely flag in bam driver to avoid > not permitted register writes in bam_init function. > > Signed-off-by: Stanimir Varbanov > Reviewed-by: Andy Gross > --- > Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++ > drivers/dma/qcom/bam_dma.c | 7 +++++++ > 2 files changed, 9 insertions(+) Acked-by: Rob Herring On being a separate patch, yes that is always the preference. However, this change is so small it doesn't matter to me. But this is going in thru Vinod's tree, so it is his call. Rob