Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932564AbcDGS7A (ORCPT ); Thu, 7 Apr 2016 14:59:00 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:36037 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932458AbcDGS66 (ORCPT ); Thu, 7 Apr 2016 14:58:58 -0400 Date: Thu, 7 Apr 2016 21:58:54 +0300 From: Cyrill Gorcunov To: Ebru Akagunduz Cc: linux-mm@kvack.org, hughd@google.com, riel@redhat.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com, aarcange@redhat.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, mgorman@suse.de, rientjes@google.com, vbabka@suse.cz, aneesh.kumar@linux.vnet.ibm.com, hannes@cmpxchg.org, mhocko@suse.cz, boaz@plexistor.com Subject: Re: [PATCH v5 2/2] mm, thp: avoid unnecessary swapin in khugepaged Message-ID: <20160407185854.GO2258@uranus.lan> References: <1460049861-10646-1-git-send-email-ebru.akagunduz@gmail.com> <1460050081-10765-1-git-send-email-ebru.akagunduz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460050081-10765-1-git-send-email-ebru.akagunduz@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 434 Lines: 12 On Thu, Apr 07, 2016 at 08:28:01PM +0300, Ebru Akagunduz wrote: ... > + swap = get_mm_counter(mm, MM_SWAPENTS); > + curr_allocstall = sum_vm_event(ALLOCSTALL); > + /* > + * When system under pressure, don't swapin readahead. > + * So that avoid unnecessary resource consuming. > + */ > + if (allocstall == curr_allocstall && swap !=) > + __collapse_huge_page_swapin(mm, vma, address, pmd); This !=) looks like someone got fun ;)