Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbcDGU6E (ORCPT ); Thu, 7 Apr 2016 16:58:04 -0400 Received: from casper.infradead.org ([85.118.1.10]:49074 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754124AbcDGU6C (ORCPT ); Thu, 7 Apr 2016 16:58:02 -0400 Date: Thu, 7 Apr 2016 22:58:00 +0200 From: Peter Zijlstra To: Alexei Starovoitov Cc: Steven Rostedt , "David S . Miller" , Ingo Molnar , Daniel Borkmann , Arnaldo Carvalho de Melo , Wang Nan , Josef Bacik , Brendan Gregg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 net-next 03/10] perf: split perf_trace_buf_prepare into alloc and update parts Message-ID: <20160407205800.GH3448@twins.programming.kicks-ass.net> References: <1459993411-2754735-1-git-send-email-ast@fb.com> <1459993411-2754735-4-git-send-email-ast@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459993411-2754735-4-git-send-email-ast@fb.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 10 On Wed, Apr 06, 2016 at 06:43:24PM -0700, Alexei Starovoitov wrote: > split allows to move expensive update of 'struct trace_entry' to later phase. > Repurpose unused 1st argument of perf_tp_event() to indicate event type. > > While splitting use temp variable 'rctx' instead of '*rctx' to avoid > unnecessary loads done by the compiler due to -fno-strict-aliasing > > Signed-off-by: Alexei Starovoitov Acked-by: Peter Zijlstra (Intel)