Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756710AbcDGXWB (ORCPT ); Thu, 7 Apr 2016 19:22:01 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40369 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbcDGXV7 (ORCPT ); Thu, 7 Apr 2016 19:21:59 -0400 Date: Thu, 7 Apr 2016 16:21:55 -0700 From: Stephen Boyd To: Sjoerd Simons Cc: Geert Uytterhoeven , Simon Horman , linux-renesas-soc@vger.kernel.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michael Turquette , linux-clk Subject: Re: [PATCH] ARM: dts: r8a7791: Don't disable referenced optional clocks Message-ID: <20160407232155.GH18567@codeaurora.org> References: <1459947173-6664-1-git-send-email-sjoerd.simons@collabora.co.uk> <1459949826.23936.19.camel@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459949826.23936.19.camel@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 34 On 04/06, Sjoerd Simons wrote: > On Wed, 2016-04-06 at 15:11 +0200, Geert Uytterhoeven wrote: > > CC Mike, Stephen, linux-clk (this time with the new Mike) > > > > On Wed, Apr 6, 2016 at 2:52 PM, Sjoerd Simons > > wrote: > > > > > > clk_get on a disabled clock node will return EPROBE_DEFER, which > > > can > > > cause drivers to be deferred forever if such clocks are referenced > > > in > > > their clocks property. > > Is this a side effect of commit 3e5dd6f6e690048d ("clk: Ignore > > disabled DT > > clock providers")? > > Yes it seems so. Reverting that patch means that i can drop this one > and get the expected behaviour again. The DT is broken then? Is it possible to mark these status = "okay" so that things work again? > > Though even so I'm not sure what the convention is for clocks like > these, the r8a7791.dtsi is inconsistent, as some are disabled while > others (e.g. the audio clocks) are 0hz. Would be good to get some input > on that regardless. > What's the question here? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project