Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757134AbcDHFkU (ORCPT ); Fri, 8 Apr 2016 01:40:20 -0400 Received: from mga04.intel.com ([192.55.52.120]:15769 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbcDHFkS (ORCPT ); Fri, 8 Apr 2016 01:40:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,449,1455004800"; d="asc'?scan'208";a="950661732" From: Felipe Balbi To: Purna Chandra Mandal , linux-kernel@vger.kernel.org Cc: Rob Herring , linux-usb@vger.kernel.org, Joshua Henderson , Cristian Birsan , Greg Kroah-Hartman , Bin Liu , Kumar Gala Subject: Re: [PATCH v2 2/2] usb: musb: pic32: Add USB DRC driver for PIC32 OTG controller. In-Reply-To: <57065847.3030105@microchip.com> References: <460027775-20729-2-git-send-email-purna.mandal@microchip.com> <1460032381-32677-1-git-send-email-purna.mandal@microchip.com> <1460032381-32677-2-git-send-email-purna.mandal@microchip.com> <874mbdr3s2.fsf@intel.com> <57065847.3030105@microchip.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Fri, 08 Apr 2016 08:38:20 +0300 Message-ID: <87vb3spsmr.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2883 Lines: 87 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Purna Chandra Mandal writes: >> Purna Chandra Mandal writes: >>> From: Cristian Birsan >>> >>> This driver adds support of PIC32 MUSB OTG controller as >>> dual role device. It implements platform specific glue to >>> reuse musb core. >>> >>> Signed-off-by: Cristian Birsan >>> Signed-off-by: Purna Chandra Mandal >>> >>> In-reply-to: 460027775-20729-2-git-send-email-purna.mandal@microchip.com >>> >>> --- >>> >>> Changes in v2: >>> - fix i386 build >>> - fix indentation >>> >>> drivers/usb/musb/Kconfig | 9 +- >>> drivers/usb/musb/Makefile | 1 + >>> drivers/usb/musb/pic32.c | 608 ++++++++++++++++++++++++++++++++++++++= ++++++++ >>> 3 files changed, 617 insertions(+), 1 deletion(-) >>> create mode 100644 drivers/usb/musb/pic32.c >>> >>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >>> index 886526b..1970c1e 100644 >>> --- a/drivers/usb/musb/Kconfig >>> +++ b/drivers/usb/musb/Kconfig >>> @@ -112,6 +112,13 @@ config USB_MUSB_BLACKFIN >>> depends on (BF54x && !BF544) || (BF52x && ! BF522 && !BF523) >>> depends on NOP_USB_XCEIV >>>=20=20 >>> +config USB_MUSB_PIC32 >>> + tristate "Microchip PIC32 USB platforms" >>> + depends on MACH_PIC32 >> no, we like to build stuff on other arches, this should be: >> >> depends on MACH_PIC32 || COMPILE_TEST >> >> and you should *really* fix the build error, not work around it. > > This driver is for PIC32MZDA platforms which are powered by MIPS 14Kec CP= U. > > The offending API 'readsl()' is implemented by MIPS arch (in > arch/mips/include/asm/io.h), but not by i386 arch. odd, asm-generic/io.h has an implementation. In any case, why couldn't you use readl() instead ? > IMO compiling for i386 is not required. it is for build coverage. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXB0PMAAoJEIaOsuA1yqREsO4P/3YowFXCWuskkuAZNXrtumIP TDR0YppCkqY2JHHny+N/PZ48dHTEalcuddMKO77GFQLYn5QiKGaMwJzXoUFFzTHe JrnKVPDfuCaFSo/u7eGan02nktz4HtyZBVrBvJbY6L8D8MtWqSzCq3y64vJ77EdQ tkG0e+T4sq1xf7sJv5Dkf04LQn102h/8HV9w0/s+8hZiZ9uhD3J5nit9izQW+CSI /GwaH/pCS3JjP8OxwBIqC69iye3F8Vf9nTorJyHbPrsYet52ViuXWmoNaOEvSOZR ofYx8fFAp41oqtqLb1EEoPRlhnk2IZkoPbigwZDZX7jL2JKlSOuOFgEQalwZAYrV sTzvCb8kODakB/sWdD4C/DrmJne1N34cAIRzSmeLeSCKdc1MkkLub1BZP2wI/Ekz mbiYIRjj/BoOXIfTDBJpXM0cmRnYcGutKf8NH5KuML5pNHODM091PjOW0+x3nRF1 w52b91L3WBEnHQxZc8xpahSv+/z2J9C7TVAwayb5sem6AXX8nNx1EPzU5V0VGfMA LGyDe3ekEWjB0wHzHvUQxLgc6tsexSpjhYugzgnlTnXXPFPN90l80TBWsfdhyqqY P6jna4aT/OW68W3/kLHFNxHs2gBmi7KLydDw5lhrDdj8jpx5v39qo6uLpaEBM6z5 O4oVrejp5k8o9rqgQ74E =oH6l -----END PGP SIGNATURE----- --=-=-=--