Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757575AbcDHGT7 (ORCPT ); Fri, 8 Apr 2016 02:19:59 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:49451 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757443AbcDHGT6 (ORCPT ); Fri, 8 Apr 2016 02:19:58 -0400 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Fri, 8 Apr 2016 08:19:49 +0200 From: Heiko Carstens To: Sebastian Andrzej Siewior Cc: Thomas Gleixner , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, rt@linutronix.de, Martin Schwidefsky , Anna-Maria Gleixner Subject: Re: [PATCH] cpu/hotplug: fix rollback during error-out in __cpu_disable() Message-ID: <20160408061949.GA3433@osiris> References: <20160405104912.GC3937@osiris> <57039DC2.6090907@linutronix.de> <20160405112336.GB6890@osiris> <20160405113637.GC6890@osiris> <20160405115129.GE30124@linutronix.de> <5703A836.7030708@linutronix.de> <20160405121155.GF6890@osiris> <20160405155904.GA19022@linutronix.de> <20160406195133.GB3485@osiris> <57067938.6030908@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57067938.6030908@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040806-0025-0000-0000-00000EE01523 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 18 On Thu, Apr 07, 2016 at 05:14:00PM +0200, Sebastian Andrzej Siewior wrote: > On 04/06/2016 09:51 PM, Heiko Carstens wrote: > > This fixes the issue that a second cpu_down() will take forever, if > > __cpu_disable() fails. > > Yes. But even without the second take down your CPU isn't complete up. > > > However it does not fix the issue that CPU_DOWN_FAILED will be seen on a > > different cpu than the cpu that was supposed to be taken offline. > > This is correct. It fixes only the regression you reported. > The CPU_DOWN_FAILED patches are on hold for now. Ok, I was bit confused here. So you may add Tested-by: Heiko Carstens if you want to :)