Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932454AbcDHIYV (ORCPT ); Fri, 8 Apr 2016 04:24:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:45203 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757295AbcDHIYT (ORCPT ); Fri, 8 Apr 2016 04:24:19 -0400 Date: Fri, 8 Apr 2016 10:24:15 +0200 From: Petr Mladek To: Josh Poimboeuf Cc: Jiri Kosina , Jessica Yu , Miroslav Benes , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Vojtech Pavlik Subject: Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for detecting reliable stack traces Message-ID: <20160408082415.GG5218@pathway.suse.cz> References: <1f8c648ed8b8eb49a75f5a6cacf8b7ca76f44fa9.1458933243.git.jpoimboe@redhat.com> <20160407115552.GB27670@pathway.suse.cz> <20160407144655.kf7ujfctdlvnwx6s@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160407144655.kf7ujfctdlvnwx6s@treble.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 548 Lines: 14 On Thu 2016-04-07 09:46:55, Josh Poimboeuf wrote: > On Thu, Apr 07, 2016 at 01:55:52PM +0200, Petr Mladek wrote: > > Well, I wonder if we should be more suspicious and make > > sure that only the regular process stack is used. > > Notice the save_stack_stack_reliable() function, which is called by > dump_trace() when the task is running on an interrupt or exception > stack. It returns -EINVAL, so the stack gets marked unreliable. Does > that address your concern, or did you mean something else? I see. It does what I wanted. Thanks, Petr