Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758021AbcDHJ1Y (ORCPT ); Fri, 8 Apr 2016 05:27:24 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:59506 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbcDHJ1W (ORCPT ); Fri, 8 Apr 2016 05:27:22 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: sugar.zhang@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: sugar.zhang@rock-chips.com X-UNIQUE-TAG: <4113688c3c843d7b38c0df5066c2a1d9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] ASoC: rockchip: i2s: configure the sdio pins' iomux mode To: Rob Herring References: <1459931902-77324-1-git-send-email-sugar.zhang@rock-chips.com> <20160407175811.GP32257@rob-hp-laptop> Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, heiko@sntech.de, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Jaroslav Kysela , linux-rockchip@lists.infradead.org, Sjoerd Simons , broonie@kernel.org, Kumar Gala , Jianqun Xu , linux-arm-kernel@lists.infradead.org From: sugar Message-ID: <57077961.6010200@rock-chips.com> Date: Fri, 8 Apr 2016 17:26:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160407175811.GP32257@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2247 Lines: 69 Hi Rob, On 4/8/2016 01:58, Rob Herring Wrote: > On Wed, Apr 06, 2016 at 04:38:22PM +0800, Sugar Zhang wrote: >> There are 3 i2s sdio pins, which iomux mode is as follows: > > s/i2s sdio/I2S\/SDIO muxed/ > >> >> - sdi3_sdo1 >> - sdi2_sdo2 >> - sdi1_sdo3 >> >> we need to configure these pins' iomux mode via the GRF register >> when use multi channel playback/capture. > > Why not a pinctrl binding here? If you want SDIO mode, then you need > similar code in the SDIO driver (or just rely on default mode). > here, i2s_sdio means i2s_sdi/i2s_sdo, not means SDIO bus interface. for example: gpio3d[6] iomux select: 2'b 00: gpio 2'b 01: i2s0_sdi3sdo1 2'b 10: xxx 2'b 11: xxx we configure the i2s_sdi3sdo1 mode via the pinctrl, and then need another grf register to configure it is used for i2s0_sdi3 or i2s0_sdo1. >> >> Signed-off-by: Sugar Zhang >> --- >> >> .../devicetree/bindings/sound/rockchip-i2s.txt | 5 +++ >> sound/soc/rockchip/rockchip_i2s.c | 39 +++++++++++++++++++++- >> sound/soc/rockchip/rockchip_i2s.h | 8 +++++ >> 3 files changed, 51 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt >> index 6e86d8a..ad72a7d 100644 >> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt >> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt >> @@ -23,6 +23,11 @@ Required properties: >> - rockchip,playback-channels: max playback channels, if not set, 8 channels default. >> - rockchip,capture-channels: max capture channels, if not set, 2 channels default. >> >> +Required properties for controller which support multi channels playback/capture: >> + >> +- rockchip,grf: Should be phandle/offset pair. the phandle of the syscon node for GRF register, > > Wrap your lines at less than 80 chars. Ok, will fix. > >> + and the offset of the GRF for control register. >> + >> Example for rk3288 I2S controller: >> >> i2s@ff890000 { > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >