Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758148AbcDHLCS (ORCPT ); Fri, 8 Apr 2016 07:02:18 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:34056 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754046AbcDHLCR (ORCPT ); Fri, 8 Apr 2016 07:02:17 -0400 MIME-Version: 1.0 In-Reply-To: <1459580269-64531-1-git-send-email-yingjoe.chen@mediatek.com> References: <1459580269-64531-1-git-send-email-yingjoe.chen@mediatek.com> From: Daniel Kurtz Date: Fri, 8 Apr 2016 19:01:56 +0800 X-Google-Sender-Auth: JxkvqLtbYdvnSzbtQ1Dl2jSfJe0 Message-ID: Subject: Re: [PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce To: Yingjoe Chen Cc: Linus Walleij , Matthias Brugger , Hongzhou Yang , "open list:PIN CONTROL SUBSYSTEM" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , "linux-kernel@vger.kernel.org" , srv_heupstream Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2254 Lines: 53 On Sat, Apr 2, 2016 at 2:57 PM, Yingjoe Chen wrote: > The debounce time unit for gpio_chip.set_debounce is us but > mtk_gpio_set_debounce regard it as ms. > Fix this by correct debounce time array dbnc_arr so it can find correct > debounce setting. Debounce time for first debounce setting is 500us, > correct this as well. > > While I'm at it, also change the debounce time array name to > "debounce_time" for readability. > > Signed-off-by: Yingjoe Chen Reviewed-by: Daniel Kurtz > --- > This was based on v4.6-rc1 > Change since v1: > - Improve commit message. > - Change dbnc_arr name to debounce_time > --- > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > index 2bbe6f7..6ab8c3c 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > @@ -1004,7 +1004,8 @@ static int mtk_gpio_set_debounce(struct gpio_chip *chip, unsigned offset, > struct mtk_pinctrl *pctl = dev_get_drvdata(chip->parent); > int eint_num, virq, eint_offset; > unsigned int set_offset, bit, clr_bit, clr_offset, rst, i, unmask, dbnc; > - static const unsigned int dbnc_arr[] = {0 , 1, 16, 32, 64, 128, 256}; > + static const unsigned int debounce_time[] = {500, 1000, 16000, 32000, 64000, > + 128000, 256000}; > const struct mtk_desc_pin *pin; > struct irq_data *d; > > @@ -1022,9 +1023,9 @@ static int mtk_gpio_set_debounce(struct gpio_chip *chip, unsigned offset, > if (!mtk_eint_can_en_debounce(pctl, eint_num)) > return -ENOSYS; > > - dbnc = ARRAY_SIZE(dbnc_arr); > - for (i = 0; i < ARRAY_SIZE(dbnc_arr); i++) { > - if (debounce <= dbnc_arr[i]) { > + dbnc = ARRAY_SIZE(debounce_time); > + for (i = 0; i < ARRAY_SIZE(debounce_time); i++) { > + if (debounce <= debounce_time[i]) { > dbnc = i; > break; > } > -- > 1.9.1 >