Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758285AbcDHLxT (ORCPT ); Fri, 8 Apr 2016 07:53:19 -0400 Received: from mga02.intel.com ([134.134.136.20]:40378 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251AbcDHLxS (ORCPT ); Fri, 8 Apr 2016 07:53:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,449,1455004800"; d="scan'208";a="950832425" From: Alexander Shishkin To: Chunyan Zhang Cc: linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, zhang.lyra@gmail.com Subject: Re: [PATCH] stm class: correct masterID range in setting via sysfs In-Reply-To: <1459151742-31733-1-git-send-email-zhang.chunyan@linaro.org> References: <1459151742-31733-1-git-send-email-zhang.chunyan@linaro.org> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 08 Apr 2016 14:53:15 +0300 Message-ID: <87d1q0xqok.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 34 Chunyan Zhang writes: > The type of masterID is defined as 'unsigned int', theoretically one > can set masterID with a number larger than 'INT_MAX' as long as > 'stm_data::sw_end' is larger than 'INT_MAX'. > > Also, 'stm_data::start' and 'stm_data::end' is initialized in respective > drivers which should be able to use any value less than 'UINT_MAX' for > their masterIDs, of course including those values larger than 'INT_MAX', > but the current policy is wrongly assuming that masterIDs would not be > larger than 'INT_MAX'. This patch just corrected that. > > Signed-off-by: Chunyan Zhang > --- > drivers/hwtracing/stm/policy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/stm/policy.c b/drivers/hwtracing/stm/policy.c > index 1db1896..ce3edfd 100644 > --- a/drivers/hwtracing/stm/policy.c > +++ b/drivers/hwtracing/stm/policy.c > @@ -107,7 +107,7 @@ stp_policy_node_masters_store(struct config_item *item, const char *page, > goto unlock; > > /* must be within [sw_start..sw_end], which is an inclusive range */ > - if (first > INT_MAX || last > INT_MAX || first > last || > + if (first > UINT_MAX || last > UINT_MAX || first > last || Of course, I wasn't paying attention, testing an unsigned integer for being greater than UINT_MAX doesn't really make sense. Regards, -- Alex