Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757599AbcDHOHG (ORCPT ); Fri, 8 Apr 2016 10:07:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58782 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753538AbcDHOHF (ORCPT ); Fri, 8 Apr 2016 10:07:05 -0400 Date: Fri, 8 Apr 2016 07:07:01 -0700 From: Greg Kroah-Hartman To: Chunfeng Yun Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] usb: core: buffer: avoid NULL pointer dereferrence Message-ID: <20160408140701.GA3547@kroah.com> References: <1460106483-24793-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460106483-24793-1-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 365 Lines: 13 On Fri, Apr 08, 2016 at 05:08:03PM +0800, Chunfeng Yun wrote: > NULL pointer dereferrence will happen when class driver > wants to allocate zero length buffer and pool_max[0] > can't be used, so skip reserved pool in this case. Why would a driver want to allocate a 0 length buffer? What driver does this? Shouldn't we fix that issue instead? thanks, greg k-h