Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758737AbcDHO6w (ORCPT ); Fri, 8 Apr 2016 10:58:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35299 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754266AbcDHO6u (ORCPT ); Fri, 8 Apr 2016 10:58:50 -0400 Date: Fri, 8 Apr 2016 11:58:47 -0300 From: Arnaldo Carvalho de Melo To: Thierry Reding Cc: linux-kernel@vger.kernel.org, Wang Nan , Jiri Olsa , Arnaldo Carvalho de Melo Subject: Re: [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified Message-ID: <20160408145847.GE5327@redhat.com> References: <1460106849-6435-1-git-send-email-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460106849-6435-1-git-send-email-thierry.reding@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 46 Em Fri, Apr 08, 2016 at 11:14:09AM +0200, Thierry Reding escreveu: > From: Thierry Reding > > The KBUILD_OUTPUT environment can be used to set the build directory as > an alternative to passing the O variable on the command-line. This works > with regular kernel builds, so it's surprising if it doesn't work within > the tools/scripts directory. > > Allow KBUILD_OUTPUT if O is not specified on the command-line to avoid > any surprises. I think this is fine, Jiri, Wang? - Arnaldo > Signed-off-by: Thierry Reding > --- > Hi Arnaldo, > > I'm not sure if you're the right person to send this to. There was noone > reported by scripts/get_maintainer.pl, but it looks like you ended up > applying most of the patches to this file lately, which kinda makes you > the de facto maintainer =). > > Thierry > > tools/scripts/Makefile.include | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include > index 8abbef164b4e..5467da41dc72 100644 > --- a/tools/scripts/Makefile.include > +++ b/tools/scripts/Makefile.include > @@ -8,6 +8,10 @@ ifeq ($(objtree),) > objtree := $(O) > endif > endif > +else > +ifneq ($(KBUILD_OUTPUT),) > + OUTPUT := $(KBUILD_OUTPUT)/$(if $(subdir),$(subdir)/) > +endif > endif > > # check that the output directory actually exists > -- > 2.8.0