Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932775AbcDHPBF (ORCPT ); Fri, 8 Apr 2016 11:01:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932725AbcDHPBC (ORCPT ); Fri, 8 Apr 2016 11:01:02 -0400 Date: Fri, 8 Apr 2016 12:00:57 -0300 From: Arnaldo Carvalho de Melo To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Aaro Koskinen , Adrian Hunter , Michal Marek , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Lukas Wunner , Jiri Olsa Subject: Re: [PATCH 1/2] kbuild: rename cmd_cc_i_c to cmd_cpp_i_c Message-ID: <20160408150057.GF5327@redhat.com> References: <1460082288-31817-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460082288-31817-1-git-send-email-yamada.masahiro@socionext.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 08 Apr 2016 15:01:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2278 Lines: 68 Em Fri, Apr 08, 2016 at 11:24:47AM +0900, Masahiro Yamada escreveu: > This command just preprocesses .c files into .i files, so cmd_cpp_i_c > seems more suitable. Thanks for doing it to the tools/build/ copy, looks sensible, I guess this can go via the kbuild tree? Acked-by: Arnaldo Carvalho de Melo - Arnaldo > Signed-off-by: Masahiro Yamada > --- > > scripts/Makefile.build | 6 +++--- > tools/build/Makefile.build | 8 ++++---- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index e1bc190..7e4df13 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -152,11 +152,11 @@ cmd_cc_s_c = $(CC) $(c_flags) $(DISABLE_LTO) -fverbose-asm -S -o $@ $< > $(obj)/%.s: $(src)/%.c FORCE > $(call if_changed_dep,cc_s_c) > > -quiet_cmd_cc_i_c = CPP $(quiet_modtag) $@ > -cmd_cc_i_c = $(CPP) $(c_flags) -o $@ $< > +quiet_cmd_cpp_i_c = CPP $(quiet_modtag) $@ > +cmd_cpp_i_c = $(CPP) $(c_flags) -o $@ $< > > $(obj)/%.i: $(src)/%.c FORCE > - $(call if_changed_dep,cc_i_c) > + $(call if_changed_dep,cpp_i_c) > > cmd_gensymtypes = \ > $(CPP) -D__GENKSYMS__ $(c_flags) $< | \ > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build > index ee566e8..27f3583 100644 > --- a/tools/build/Makefile.build > +++ b/tools/build/Makefile.build > @@ -58,8 +58,8 @@ quiet_cmd_mkdir = MKDIR $(dir $@) > quiet_cmd_cc_o_c = CC $@ > cmd_cc_o_c = $(CC) $(c_flags) -c -o $@ $< > > -quiet_cmd_cc_i_c = CPP $@ > - cmd_cc_i_c = $(CC) $(c_flags) -E -o $@ $< > +quiet_cmd_cpp_i_c = CPP $@ > + cmd_cpp_i_c = $(CC) $(c_flags) -E -o $@ $< > > quiet_cmd_cc_s_c = AS $@ > cmd_cc_s_c = $(CC) $(c_flags) -S -o $@ $< > @@ -83,11 +83,11 @@ $(OUTPUT)%.o: %.S FORCE > > $(OUTPUT)%.i: %.c FORCE > $(call rule_mkdir) > - $(call if_changed_dep,cc_i_c) > + $(call if_changed_dep,cpp_i_c) > > $(OUTPUT)%.s: %.S FORCE > $(call rule_mkdir) > - $(call if_changed_dep,cc_i_c) > + $(call if_changed_dep,cpp_i_c) > > $(OUTPUT)%.s: %.c FORCE > $(call rule_mkdir) > -- > 1.9.1