Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758765AbcDHRaN (ORCPT ); Fri, 8 Apr 2016 13:30:13 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:51764 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753723AbcDHRaJ (ORCPT ); Fri, 8 Apr 2016 13:30:09 -0400 Subject: Re: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem To: "Winkler, Tomas" , "vinholikatti@gmail.com" , "martin.petersen@oracle.com" , "Joao.Pinto@synopsys.com" , "James.Bottomley@HansenPartnership.com" , "gregkh@linuxfoundation.org" , "luto@kernel.org" , "ulf.hansson@linaro.org" , "Hunter, Adrian" References: <1459768284-26997-1-git-send-email-tomas.winkler@intel.com> <1459768284-26997-9-git-send-email-tomas.winkler@intel.com> <5704CE0B.2010700@synopsys.com> <1460063682.4468.7.camel@intel.com> CC: "hch@lst.de" , "linux-mmc@vger.kernel.org" , "ygardi@codeaurora.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Usyskin, Alexander" From: Joao Pinto Message-ID: <5707EA97.2050408@synopsys.com> Date: Fri, 8 Apr 2016 18:29:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1460063682.4468.7.camel@intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 50 Hi, On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: >> Hi! >> >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: >>> Register UFS RPMB LUN with the RPMB subsystem and provide >>> implementation for the RPMB access operations. RPMB partition is >>> accessed via a sequence of security protocol in and security >>> protocol >>> out commands with UFS specific parameters. This multi step process >>> is >>> abstracted into 4 basic RPMB commands. >> >> [snip] >> >>> * "UFS device" W-LU. >>> */ >>> struct scsi_device *sdev_ufs_device; >>> + struct scsi_device *sdev_ufs_rpmb; >>> >>> enum ufs_dev_pwr_mode curr_dev_pwr_mode; >>> enum uic_link_state uic_link_state; >>> >> >> I have a UFS device emulator that has the RPMB capability. What are >> the expected >> good results for me to validate? > > Hi Joao, thanks for that. I'm attaching an archive with few basic > samples via user space interface. > You should run the program key first (program-key.sh), just don't do it > on a real device it's one in life time operation. > Managed to cross-compile to ARC and execute your test app in my platform. I made it in Buildroot, so I have the patches to enable the tool cross-compilation if necessary in the future. The tool execution gives no errors, but also no info. I suggest you had success info and maybe some statistic (e.g. bytes read or written). > Thanks > Tomas > Thanks, Joao