Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758848AbcDHShM (ORCPT ); Fri, 8 Apr 2016 14:37:12 -0400 Received: from mga02.intel.com ([134.134.136.20]:23512 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758534AbcDHShK convert rfc822-to-8bit (ORCPT ); Fri, 8 Apr 2016 14:37:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,454,1455004800"; d="scan'208";a="780993971" From: "Yu, Fenghua" To: Herbert Xu , "megha.dey@linux.intel.com" CC: "davem@davemloft.net" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tim.c.chen@linux.intel.com" , "Dey, Megha" Subject: RE: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code Thread-Topic: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code Thread-Index: AQHRhgrm1Igd1IgrWk6VII5qChJpYp97z7mAgASu6DA= Date: Fri, 8 Apr 2016 18:37:05 +0000 Message-ID: <3E5A0FA7E9CA944F9D5414FEC6C712205DFA3CFB@ORSMSX106.amr.corp.intel.com> References: <1458851163-3448-1-git-send-email-megha.dey@linux.intel.com> <1458851163-3448-3-git-send-email-megha.dey@linux.intel.com> <20160405120357.GA12510@gondor.apana.org.au> In-Reply-To: <20160405120357.GA12510@gondor.apana.org.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 37 > From: Herbert Xu [mailto:herbert@gondor.apana.org.au] > Sent: Tuesday, April 05, 2016 5:04 AM > To: megha.dey@linux.intel.com > Cc: davem@davemloft.net; linux-crypto@vger.kernel.org; linux- > kernel@vger.kernel.org; tim.c.chen@linux.intel.com; Yu, Fenghua > ; Dey, Megha > Subject: Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job > manager and glue code > > On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@linux.intel.com > wrote: > > From: Megha Dey > > > > This patch introduces the multi-buffer job manager which is > > responsible for submitting scatter-gather buffers from several SHA256 > > jobs to the multi-buffer algorithm. It also contains the flush routine > > to that's called by the crypto daemon to complete the job when no new > > jobs arrive before the deadline of maximum latency of a SHA256 crypto job. > > > > The SHA256 multi-buffer crypto algorithm is defined and initialized in > > this patch. > > > > Signed-off-by: Megha Dey > > Reviewed-by: Fenghua Yu > > Reviewed-by: Tim Chen > > sha1-mb still has the same issues that I complained about for the aes-mb > submission. In particular, I don't like the use of shash to handle what is really > an async implmentation. > > So I'd like to see this fixed first before we add any more copies of this code. We will update the patches and re-send out sha1/256/512 AVX2 mb algos using async implementation. Thanks. -Fenghua