Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758855AbcDHTqL (ORCPT ); Fri, 8 Apr 2016 15:46:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48504 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757932AbcDHTqK (ORCPT ); Fri, 8 Apr 2016 15:46:10 -0400 Message-ID: <57080A80.3090201@redhat.com> Date: Fri, 08 Apr 2016 21:46:08 +0200 From: Denys Vlasenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Bob Peterson CC: Steven Whitehouse , cluster-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/gfs2/glock.c: Deinline do_error, save 1856 bytes References: <1460141926-13069-1-git-send-email-dvlasenk@redhat.com> <1460141926-13069-4-git-send-email-dvlasenk@redhat.com> <1824612152.49246801.1460143078420.JavaMail.zimbra@redhat.com> In-Reply-To: <1824612152.49246801.1460143078420.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 404 Lines: 9 On 04/08/2016 09:17 PM, Bob Peterson wrote: > ----- Original Message ----- >> This function compiles to 522 bytes of machine code. >> > Is there a reason why you want to trade memory for speed? Are you > optimizing for memory on an embedded device or something? Yes. I did a scan for really large inlines and this function came up. If you feel it is indeed performance critical, please ignore my patch.