Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758932AbcDHUdn (ORCPT ); Fri, 8 Apr 2016 16:33:43 -0400 Received: from mga02.intel.com ([134.134.136.20]:37883 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758916AbcDHUdl (ORCPT ); Fri, 8 Apr 2016 16:33:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,454,1455004800"; d="scan'208";a="928538261" From: "Winkler, Tomas" To: Joao Pinto , "vinholikatti@gmail.com" , "martin.petersen@oracle.com" , "James.Bottomley@HansenPartnership.com" , "gregkh@linuxfoundation.org" , "luto@kernel.org" , "ulf.hansson@linaro.org" , "Hunter, Adrian" CC: "hch@lst.de" , "linux-mmc@vger.kernel.org" , "ygardi@codeaurora.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Usyskin, Alexander" Subject: RE: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem Thread-Topic: [PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem Thread-Index: AQHRjmMjy23BbNjkGUe8wMitEs4kY598c+yAgAJiAwCAAVOMgIAAYKdA Date: Fri, 8 Apr 2016 20:33:28 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B54225677@hasmsx108.ger.corp.intel.com> References: <1459768284-26997-1-git-send-email-tomas.winkler@intel.com> <1459768284-26997-9-git-send-email-tomas.winkler@intel.com> <5704CE0B.2010700@synopsys.com> <1460063682.4468.7.camel@intel.com> <5707EA97.2050408@synopsys.com> In-Reply-To: <5707EA97.2050408@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u38KY7bu018600 Content-Length: 1841 Lines: 50 > > On 4/7/2016 10:15 PM, Winkler, Tomas wrote: > > On Wed, 2016-04-06 at 09:51 +0100, Joao Pinto wrote: > >> Hi! > >> > >> On 4/4/2016 12:11 PM, Tomas Winkler wrote: > >>> Register UFS RPMB LUN with the RPMB subsystem and provide > >>> implementation for the RPMB access operations. RPMB partition is > >>> accessed via a sequence of security protocol in and security > >>> protocol out commands with UFS specific parameters. This multi step > >>> process is abstracted into 4 basic RPMB commands. > >> > >> [snip] > >> > >>> * "UFS device" W-LU. > >>> */ > >>> struct scsi_device *sdev_ufs_device; > >>> + struct scsi_device *sdev_ufs_rpmb; > >>> > >>> enum ufs_dev_pwr_mode curr_dev_pwr_mode; > >>> enum uic_link_state uic_link_state; > >>> > >> > >> I have a UFS device emulator that has the RPMB capability. What are > >> the expected good results for me to validate? > > > > Hi Joao, thanks for that. I'm attaching an archive with few basic > > samples via user space interface. > > You should run the program key first (program-key.sh), just don't do > > it on a real device it's one in life time operation. > > > > Managed to cross-compile to ARC and execute your test app in my platform. > I made it in Buildroot, so I have the patches to enable the tool cross- > compilation if necessary in the future. > Sounds like fun :) I've just tried to follow the standard under tools, though this it's not something really generic which was surpising to me as this is in the kernel tree. > The tool execution gives no errors, but also no info. I suggest you had success > info and maybe some statistic (e.g. bytes read or written). It did have some verbose print outs on both ends, but I've cleaned it out. It was meant to be an example rather than unit testing tool, but we can repurpose it. Thanks Toma Thanks Tomas