Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758934AbcDHUvG (ORCPT ); Fri, 8 Apr 2016 16:51:06 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36828 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753699AbcDHUvE (ORCPT ); Fri, 8 Apr 2016 16:51:04 -0400 Date: Fri, 08 Apr 2016 16:51:00 -0400 (EDT) Message-Id: <20160408.165100.1546798904754346458.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch, f.fainelli@gmail.com, jiri@resnulli.us, sfeldma@gmail.com Subject: Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops From: David Miller In-Reply-To: <1459958105-1090-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1459958105-1090-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Apr 2016 13:51:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 604 Lines: 16 From: Vivien Didelot Date: Wed, 6 Apr 2016 11:55:02 -0400 > Neither the DSA layer nor the bridge code (see br_set_state) really care > about eventual errors from STP state setters, so make it void. > > The DSA layer separates the prepare and commit phases of switchdev in > two different functions. Logical errors must not happen in commit > routines, so make them void. > > Changes v1 -> v2: > - rename port_stp_update to port_stp_state_set > - don't change code flow of bcm_sf2_sw_br_set_stp_state > - prefer netdev_err over netdev_warn Series applied.