MIME-Version: 1.0
In-Reply-To: <CALCETrWKb-OZuRrjxk7f4KD2zXEMs2j5ONj+dXcvyx65-nDcYA@mail.gmail.com>
References: <1459960170-4454-1-git-send-email-dsafonov@virtuozzo.com>
 <1459960170-4454-2-git-send-email-dsafonov@virtuozzo.com> <CALCETrUhLVmHtEnt-RFMdPJ3E2T_798iWvkM8ciw=pydWCWjbw@mail.gmail.com>
 <57064E6C.2030202@virtuozzo.com> <CALCETrVNTC9DmKbrYvEDLiAa3s+ZQNyCChk7Y1F6cw6Qv3OuJg@mail.gmail.com>
 <5707B70F.9080402@virtuozzo.com> <CALCETrUU1iTcvfcxYHU6CMacyZrjxiphGB3r5U_4oof7zDd82g@mail.gmail.com>
 <5707D9F1.3090102@virtuozzo.com> <CALCETrWKb-OZuRrjxk7f4KD2zXEMs2j5ONj+dXcvyx65-nDcYA@mail.gmail.com>
From: Dmitry Safonov <0x7f454c46@gmail.com>
Date: Sat, 9 Apr 2016 11:06:08 +0300
Message-ID: <CAJwJo6b=17Q7L-ryqpsXTMoaL9UP1U-gPK0Cm8Oy+r=-OTE=Dg@mail.gmail.com>
Subject: Re: [PATCH 1/2] x86/arch_prctl: add ARCH_SET_{COMPAT,NATIVE} to
 change compatible mode
To: Andy Lutomirski <luto@amacapital.net>
Cc: Dmitry Safonov <dsafonov@virtuozzo.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Shuah Khan <shuahkh@osg.samsung.com>, Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>, khorenko@virtuozzo.com,
        X86 ML <x86@kernel.org>, Andrew Morton <akpm@linux-foundation.org>,
        xemul@virtuozzo.com, linux-kselftest@vger.kernel.org,
        Cyrill Gorcunov <gorcunov@openvz.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 965
Lines: 32

2016-04-08 23:44 GMT+03:00 Andy Lutomirski <luto@amacapital.net>:
> On Apr 8, 2016 9:20 AM, "Dmitry Safonov" <dsafonov@virtuozzo.com> wrote:
>>
>>
>> And if it's not there - return error?
>
> No, just leave IP unchanged.

Ok, will resend with this fixup.

>
> Feel free to ask for help on some of these details.  user_64bit_mode
> will be helpful too.

Thanks.

>> I doubt, is it sane to remove
>> TS_COMPAT instead, leaving TIF_IA32, as for some cases
>> we need to know if task is compatible outside of syscall's path?
>
> No.  TS_COMPAT is important, and it's also better behaved than
> TIF_IA32 -- it has a very specific meaning: "am I currently executing
> a 32-bit syscall".
>
>
> The comment is wrong :). TS_COMPAT is true on int80 or 32-bit vdso
> syscall entries and is false otherwise.  64-bit tasks can use int80
> and, with your patches, will be able to use the 32-bit vdso entry as
> well.
>

Oh, yes, I see what you pointing, thanks, will work on it.