Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbcDILik (ORCPT ); Sat, 9 Apr 2016 07:38:40 -0400 Received: from foss.arm.com ([217.140.101.70]:42989 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721AbcDILii (ORCPT ); Sat, 9 Apr 2016 07:38:38 -0400 Date: Sat, 9 Apr 2016 12:38:25 +0100 From: Marc Zyngier To: Jon Hunter Cc: Thomas Gleixner , Jason Cooper , =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Stephen Warren , "Thierry Reding" , Kevin Hilman , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Linus Walleij , , , , Subject: Re: [PATCH 10/15] irqchip/gic: Remove static irq_chip definition for eoimode1 Message-ID: <20160409123825.3550eb16@arm.com> In-Reply-To: <1458224359-32665-11-git-send-email-jonathanh@nvidia.com> References: <1458224359-32665-1-git-send-email-jonathanh@nvidia.com> <1458224359-32665-11-git-send-email-jonathanh@nvidia.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 546 Lines: 17 On Thu, 17 Mar 2016 14:19:14 +0000 Jon Hunter wrote: > There are only 3 differences (not including the name) in the definitions > of the gic_chip and gic_eoimode1_chip structures. Instead of statically > defining the gic_eoimode1_chip structure, remove it and populate the > eoimode1 functions dynamically for the appropriate GIC irqchips. > > Signed-off-by: Jon Hunter Linus' remark notwithstanding, Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.