Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbcDJDLp (ORCPT ); Sat, 9 Apr 2016 23:11:45 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35539 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbcDJDLn (ORCPT ); Sat, 9 Apr 2016 23:11:43 -0400 Date: Sun, 10 Apr 2016 12:11:38 +0900 (JST) Message-Id: <20160410.121138.2044396586371844072.konishi.ryusuke@lab.ntt.co.jp> To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nilfs2: constify nilfs_sc_operations structures From: Ryusuke Konishi In-Reply-To: <1460190503-8672-1-git-send-email-Julia.Lawall@lip6.fr> References: <1460190503-8672-1-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: Mew version 6.6 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2427 Lines: 67 On Sat, 9 Apr 2016 10:28:23 +0200, Julia Lawall wrote: > The nilfs_sc_operations structures are never modified, so declare them > as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Applied, thanks. Ryusuke Konishi > --- > fs/nilfs2/segment.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c > index 4317f72..483e663 100644 > --- a/fs/nilfs2/segment.c > +++ b/fs/nilfs2/segment.c > @@ -617,7 +617,7 @@ static void nilfs_write_file_node_binfo(struct nilfs_sc_info *sci, > *vblocknr = binfo->bi_v.bi_vblocknr; > } > > -static struct nilfs_sc_operations nilfs_sc_file_ops = { > +static const struct nilfs_sc_operations nilfs_sc_file_ops = { > .collect_data = nilfs_collect_file_data, > .collect_node = nilfs_collect_file_node, > .collect_bmap = nilfs_collect_file_bmap, > @@ -666,7 +666,7 @@ static void nilfs_write_dat_node_binfo(struct nilfs_sc_info *sci, > *binfo_dat = binfo->bi_dat; > } > > -static struct nilfs_sc_operations nilfs_sc_dat_ops = { > +static const struct nilfs_sc_operations nilfs_sc_dat_ops = { > .collect_data = nilfs_collect_dat_data, > .collect_node = nilfs_collect_file_node, > .collect_bmap = nilfs_collect_dat_bmap, > @@ -674,7 +674,7 @@ static struct nilfs_sc_operations nilfs_sc_dat_ops = { > .write_node_binfo = nilfs_write_dat_node_binfo, > }; > > -static struct nilfs_sc_operations nilfs_sc_dsync_ops = { > +static const struct nilfs_sc_operations nilfs_sc_dsync_ops = { > .collect_data = nilfs_collect_file_data, > .collect_node = NULL, > .collect_bmap = NULL, > @@ -1043,7 +1043,7 @@ static size_t nilfs_segctor_buffer_rest(struct nilfs_sc_info *sci) > > static int nilfs_segctor_scan_file(struct nilfs_sc_info *sci, > struct inode *inode, > - struct nilfs_sc_operations *sc_ops) > + const struct nilfs_sc_operations *sc_ops) > { > LIST_HEAD(data_buffers); > LIST_HEAD(node_buffers); > @@ -1550,7 +1550,7 @@ nilfs_segctor_update_payload_blocknr(struct nilfs_sc_info *sci, > sector_t blocknr; > unsigned long nfinfo = segbuf->sb_sum.nfinfo; > unsigned long nblocks = 0, ndatablk = 0; > - struct nilfs_sc_operations *sc_op = NULL; > + const struct nilfs_sc_operations *sc_op = NULL; > struct nilfs_segsum_pointer ssp; > struct nilfs_finfo *finfo = NULL; > union nilfs_binfo binfo; >