Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755303AbcDJPwv (ORCPT ); Sun, 10 Apr 2016 11:52:51 -0400 Received: from casper.infradead.org ([85.118.1.10]:33383 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbcDJPwu (ORCPT ); Sun, 10 Apr 2016 11:52:50 -0400 Date: Sun, 10 Apr 2016 16:52:46 +0100 (BST) From: James Simmons To: Greg Kroah-Hartman cc: Jeff Mahoney , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Oleg Drokin , Lustre Development List Subject: Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64 In-Reply-To: <20160410153507.GA1326@kroah.com> Message-ID: References: <1460294020-2111-1-git-send-email-jsimmons@infradead.org> <1460294020-2111-14-git-send-email-jsimmons@infradead.org> <63807394-FF62-4376-95FD-412309D47BF7@suse.com> <20160410153507.GA1326@kroah.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160410_165246_061899_3773F19A X-CRM114-Status: GOOD ( 16.56 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.0 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 17 > > > This patch was shown not to work. I just haven't removed it from opensuse yet. > > > > Its been running in our production tree as well for some time. Guess that > > change is a noop. In any case we have been discussing redoing the lloop > > driver anyways. Just need to find the cycles. > > Why do you need this driver? I know Christoph has pointed out many > times that it should just be dropped as it's not needed. Please don't drop this driver just yet. The reason we kept it was for the DIO support that the loop back device lacked earlier. We need to do some testing to make sure the loop can completely replace this driver. > And should I drop this patch from the series? Yes since it is a noop. No other patches are dependent on it.