Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932270AbcDJStS (ORCPT ); Sun, 10 Apr 2016 14:49:18 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33888 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754337AbcDJStN (ORCPT ); Sun, 10 Apr 2016 14:49:13 -0400 Subject: Re: [PATCH 2/2] tty: Remove stale parameter comment To: Jiri Slaby , Greg Kroah-Hartman References: <1460259399-11982-1-git-send-email-peter@hurleysoftware.com> <1460259399-11982-2-git-send-email-peter@hurleysoftware.com> <570A0DA9.7060301@suse.cz> Cc: linux-kernel@vger.kernel.org From: Peter Hurley Message-ID: <570AA025.1010200@hurleysoftware.com> Date: Sun, 10 Apr 2016 11:49:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <570A0DA9.7060301@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 32 On 04/10/2016 01:24 AM, Jiri Slaby wrote: > On 04/10/2016, 05:36 AM, Peter Hurley wrote: >> noctty was removed as a parameter by commit 216513411937586 > > It is actually 11e1d4aa4da. Right; not sure where that number came from. > >> ("tty: Consolidate noctty check in tty_open()"). >> >> Signed-off-by: Peter Hurley >> --- >> drivers/tty/tty_io.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c >> index 3cdd63b..50979be 100644 >> --- a/drivers/tty/tty_io.c >> +++ b/drivers/tty/tty_io.c >> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp) >> * tty_lookup_driver - lookup a tty driver for a given device file >> * @device: device number >> * @filp: file pointer to tty >> - * @noctty: set if the device should not become a controlling tty >> * @index: index for the device in the @return driver >> * @return: driver for this inode (with increased refcount) >> * >> > >