Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbcDJVNt (ORCPT ); Sun, 10 Apr 2016 17:13:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:36939 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbcDJVNr (ORCPT ); Sun, 10 Apr 2016 17:13:47 -0400 Subject: Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64 To: James Simmons References: <1460294020-2111-1-git-send-email-jsimmons@infradead.org> <1460294020-2111-14-git-send-email-jsimmons@infradead.org> <63807394-FF62-4376-95FD-412309D47BF7@suse.com> Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List From: Jeff Mahoney Message-ID: <570AC200.2020401@suse.com> Date: Sun, 10 Apr 2016 17:13:36 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="juF6tJ69aiJ3TvGRMpUgt4pqPq6ScNqVr" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4830 Lines: 131 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --juF6tJ69aiJ3TvGRMpUgt4pqPq6ScNqVr Content-Type: multipart/mixed; boundary="aRbqA8QqR9jApro0cuhwAPaX3bWp3Skf8" From: Jeff Mahoney To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List Message-ID: <570AC200.2020401@suse.com> Subject: Re: [PATCH 13/17] staging: lustre: lloop: Fix build failure on ppc64 References: <1460294020-2111-1-git-send-email-jsimmons@infradead.org> <1460294020-2111-14-git-send-email-jsimmons@infradead.org> <63807394-FF62-4376-95FD-412309D47BF7@suse.com> In-Reply-To: --aRbqA8QqR9jApro0cuhwAPaX3bWp3Skf8 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/10/16 10:04 AM, James Simmons wrote: >=20 >> This patch was shown not to work. I just haven't removed it from opens= use yet. >=20 > Its been running in our production tree as well for some time. Guess th= at=20 > change is a noop. In any case we have been discussing redoing the lloop= =20 > driver anyways. Just need to find the cycles. I guess my memory was flakey and I was recalling the first comments in LU-4000. The updated version should be ok. -Jeff >> -- >> Jeff Mahoney >> (apologies for the top post -- from my mobile) >> >>> On Apr 10, 2016, at 9:13 AM, James Simmons w= rote: >>> >>> From: Jeff Mahoney >>> >>> On ppc64 with 64k pages, we get a build failure in lloop: >>> >>> drivers/staging/lustre/lustre/llite/lloop.c:527:2: >>> note: in expansion of macro 'CLASSERT' >>> CLASSERT(PAGE_CACHE_SIZE < (1 << (sizeof(unsigned short) * 8))); >>> >>> There's no need to change the queue's logical block size. Even if it = could >>> accept a 64k value, that would result in any file system on top of it= >>> needing to also use 64k blocks. It'd be safe to set it to 4k, but the= re's >>> no actual need for it. It's not used to split requests except for WRI= TE_SAME, >>> which lloop doesn't implement anyway. >>> >>> Signed-off-by: Jeff Mahoney >>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4000 >>> Reviewed-on: http://review.whamcloud.com/7745 >>> Reviewed-by: Jinshan Xiong >>> Reviewed-by: Minh Diep >>> Reviewed-by: Oleg Drokin >>> Signed-off-by: James Simmons >>> --- >>> drivers/staging/lustre/lustre/llite/lloop.c | 3 --- >>> 1 files changed, 0 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/staging/lustre/lustre/llite/lloop.c b/drivers/st= aging/lustre/lustre/llite/lloop.c >>> index b725fc1..f396753 100644 >>> --- a/drivers/staging/lustre/lustre/llite/lloop.c >>> +++ b/drivers/staging/lustre/lustre/llite/lloop.c >>> @@ -525,9 +525,6 @@ static int loop_set_fd(struct lloop_device *lo, s= truct file *unused, >>> lo->lo_queue->queuedata =3D lo; >>> >>> /* queue parameters */ >>> - CLASSERT(PAGE_CACHE_SIZE < (1 << (sizeof(unsigned short) * 8)));= >>> - blk_queue_logical_block_size(lo->lo_queue, >>> - (unsigned short)PAGE_CACHE_SIZE); >>> blk_queue_max_hw_sectors(lo->lo_queue, >>> LLOOP_MAX_SEGMENTS << (PAGE_CACHE_SHIFT - 9)); >>> blk_queue_max_segments(lo->lo_queue, LLOOP_MAX_SEGMENTS); >>> --=20 >>> 1.7.1 >>> >>> >> >> >=20 --=20 Jeff Mahoney SUSE Labs --aRbqA8QqR9jApro0cuhwAPaX3bWp3Skf8-- --juF6tJ69aiJ3TvGRMpUgt4pqPq6ScNqVr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2 iQIcBAEBCAAGBQJXCsIEAAoJEB57S2MheeWyne4P/Amv7dBFG0uJtaV6+93aV5bm OGqh/bk0JpjZSFhzYwL+B6yrGukaIacjNBD40MhrPed4amC9P/gM9NiLxx195Ulb ybxfgB2JXKiAdNy21tTlAdszn1wrSCGQVqufF7aRNgd31a1opgrvnUW0YW/D6OT8 +3zuqTRjOgHDldaUsw6oyKHiFtLeXWuhQbfCDNCVKE0YRKqrikAAvm52b65MP5xd T7nPqFWX1hyPMk/Z/Qm7C2tylMd31DWAnC9Ca7/LQx4J0mx8IYMryE6ntr7CwbaH nBAjw8UH7O/I2Rn8Ea+pJSn9Ka3FUJjcmH9/IBix+bcK1SQbJELNRhfobBxtwFPe xI/iCEsHd3cCrOgcXzJ7VPJechB1Yy9shbAQEVggJ7FpwPWoO9Ifewg+1Vq0fd2w 3POCn9X/sWt0/eZopMSQuA4gMLHWxbauMEq3Gs60NY9ZYH5E9Tmorsrc/PD/bP7t HrbsDxJ4MTB40iADVuRs7WbtjpsLwOsW5gY81pnSol3U+rTFM6kPpvsNTd82ha5U Uy/F2CUZgJK0IoKSTbWotDck7vDuqLRnVxkuERba0VbY04NrjUfx/wdfjKWRUeZn xU8cfHEJ9peOKbgEdOnOHrl6xrGJSPDSDj7SNqGiVNQDODl4bj7Sd7yxTE8HO6jY s0jrLgRXO3dsRvBEI8a4 =Md1t -----END PGP SIGNATURE----- --juF6tJ69aiJ3TvGRMpUgt4pqPq6ScNqVr--