Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbcDJXoL (ORCPT ); Sun, 10 Apr 2016 19:44:11 -0400 Received: from pygmy.kinoho.net ([134.0.27.24]:44134 "EHLO pygmy.kinoho.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbcDJXoI (ORCPT ); Sun, 10 Apr 2016 19:44:08 -0400 From: Grigori Goronzy To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Grigori Goronzy Subject: [PATCH v3 04/13] USB: ch341: fix USB buffer allocations Date: Mon, 11 Apr 2016 01:43:44 +0200 Message-Id: <1460331833-19836-5-git-send-email-greg@chown.ath.cx> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1460331833-19836-1-git-send-email-greg@chown.ath.cx> References: <1460331833-19836-1-git-send-email-greg@chown.ath.cx> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1291 Lines: 48 Use the correct types and sizes. v2: use u8 shorthand for unsigned char. Signed-off-by: Grigori Goronzy --- drivers/usb/serial/ch341.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index db4b561..95c8a40 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -115,7 +115,7 @@ static int ch341_control_out(struct usb_device *dev, u8 request, static int ch341_control_in(struct usb_device *dev, u8 request, u16 value, u16 index, - char *buf, unsigned bufsize) + u8 *buf, unsigned bufsize) { int r; @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device *dev, u8 control) static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv) { - char *buffer; + unsigned char *buffer; int r; - const unsigned size = 8; + const unsigned size = 2; unsigned long flags; buffer = kmalloc(size, GFP_KERNEL); @@ -198,9 +198,9 @@ out: kfree(buffer); static int ch341_configure(struct usb_device *dev, struct ch341_private *priv) { - char *buffer; + unsigned char *buffer; int r; - const unsigned size = 8; + const unsigned size = 2; buffer = kmalloc(size, GFP_KERNEL); if (!buffer) -- 1.9.1