Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbcDKCws (ORCPT ); Sun, 10 Apr 2016 22:52:48 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:45424 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbcDKCwq (ORCPT ); Sun, 10 Apr 2016 22:52:46 -0400 X-263anti-spam: BIG:0;ABS:1;DNS:0;ATT:0;SPF:S;KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <570B1171.7040402@rock-chips.com> Date: Mon, 11 Apr 2016 10:52:33 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: John Keeping CC: Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/rockchip: remove redundant statement References: <1459864232-25033-1-git-send-email-john@metanate.com> In-Reply-To: <1459864232-25033-1-git-send-email-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 949 Lines: 28 On 2016年04月05日 21:50, John Keeping wrote: > The call to arm_iommu_detach_device() on the previous line sets > dev->archdata.mapping to NULL so this call is always a no-op. > > Signed-off-by: John Keeping > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index f556a8f..7695c79 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -244,7 +244,6 @@ static int rockchip_drm_unload(struct drm_device *drm_dev) > drm_kms_helper_poll_fini(drm_dev); > component_unbind_all(dev, drm_dev); > arm_iommu_detach_device(dev); > - arm_iommu_release_mapping(dev->archdata.mapping); > drm_mode_config_cleanup(drm_dev); > drm_dev->dev_private = NULL; > Applied to my drm-fixes Thanks.:-) -- Ｍark Yao