Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbcDKDqf (ORCPT ); Sun, 10 Apr 2016 23:46:35 -0400 Received: from mail-db3on0096.outbound.protection.outlook.com ([157.55.234.96]:10528 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750964AbcDKDqe convert rfc822-to-8bit (ORCPT ); Sun, 10 Apr 2016 23:46:34 -0400 From: Rajesh Bhagat To: Mathias Nyman CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sriram Dash Subject: RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout Thread-Topic: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout Thread-Index: AQHRgOP0koj0An7NrUiFwLeaADZ9zZ9fDpyAgAQ7AdCAAFktgIABTHuggAB1NoCAAQay8IAAsdaAgAdP/gCAAk/0gIACPkawgAC4cQCAANwGQIAAdveAgA9AtSA= Date: Mon, 11 Apr 2016 03:46:28 +0000 Message-ID: References: <1458284463-12743-1-git-send-email-rajesh.bhagat@nxp.com> <56EBE485.1060301@linux.intel.com> <56EFBBD1.6080600@intel.com> <56F1350B.7000006@linux.intel.com> <56F2A697.1000701@linux.intel.com> <56FAB97F.4030206@linux.intel.com> <56FD35F4.3020005@linux.intel.com> <56FE5251.5020806@linux.intel.com> In-Reply-To: <56FE5251.5020806@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 7a7d5ba3-abca-4941-8866-08d361bbdd67 x-microsoft-exchange-diagnostics: 1;HE1PR0401MB2026;5:/KSyBMazbu7ii8OCu9ik+C6rhowHc0xq3weFLa8XEfP456mwDJ08socbQvmzFo+6H9Kft22EyCPORbb954MQtKkb3HgocZ5fMWUBvvO+QjX01FX1Gw3rd+L+3ockD9u3qJ1yxkpAqhDEvoIPgDp7cw==;24:jS7HWxPDcw+Vg3MmKdfG15wYnu78Pn1K6HRnKB+AyQbpr2Byo7754bjlclBq4loqgH3RxvyMjkA8xfFRc14vufl8fW8kpSZhVLWct5UcotI= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0401MB2026; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:HE1PR0401MB2026;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0401MB2026; x-forefront-prvs: 09090B6B69 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(24454002)(13464003)(92566002)(3280700002)(77096005)(5008740100001)(19580395003)(19580405001)(5002640100001)(3846002)(6116002)(102836003)(5003600100002)(9686002)(2950100001)(2900100001)(1096002)(3660700001)(586003)(4326007)(1220700001)(2906002)(10400500002)(110136002)(122556002)(33656002)(66066001)(86362001)(87936001)(76576001)(81166005)(93886004)(11100500001)(106116001)(5004730100002)(189998001)(54356999)(50986999)(76176999)(74316001)(49343001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0401MB2026;H:HE1PR0401MB2028.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2016 03:46:28.8044 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2026 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1245 Lines: 41 > -----Original Message----- > From: Mathias Nyman [mailto:mathias.nyman@linux.intel.com] > Sent: Friday, April 01, 2016 4:20 PM > To: Rajesh Bhagat > Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux- > kernel@vger.kernel.org; Sriram Dash > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 01.04.2016 06:55, Rajesh Bhagat wrote: > > >>> > >>> Please share your opinion on other changes for patch submission as > >>> well as resume > >> time. > >>> > > > >> > >> I think more effort should be put into investigating why this happens in the first > place. > >> What is the root cause? why doesn't xhci start properly after resume in this case. > >> > > Hello Mathias, > > > > I understand your point and would surely debug the root cause of the > > issue. But implementing the fallback mechanism in SW, if HW does not respond well > seems to a better solution to me. > > > > Yes, I'll add something like this, at least the xhci parts to make sure the completions > are called. > Should I send the patch? > This is not really a fallback, it's just a better burial for xhci. It will be unusable after > this. > > -Mathias