Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbcDKFXR (ORCPT ); Mon, 11 Apr 2016 01:23:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:63867 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbcDKFXP (ORCPT ); Mon, 11 Apr 2016 01:23:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,462,1455004800"; d="asc'?scan'208";a="942467397" From: Felipe Balbi To: Denys Vlasenko , Felipe Balbi Cc: Denys Vlasenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes In-Reply-To: <1460145329-14897-1-git-send-email-dvlasenk@redhat.com> References: <1460145329-14897-1-git-send-email-dvlasenk@redhat.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Mon, 11 Apr 2016 08:21:15 +0300 Message-ID: <87k2k4pvp0.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2536 Lines: 77 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Denys Vlasenko writes: > This function compiles to 298 bytes of machine code, has ~10 callsites. fair enough > This is a USB 2.0 device, USB 2.0 is limited to 35 MB/s, so should be it's not limited to 35MB/sec, sorry. USB 2.0 has a theoretical maximum of 60MB/sec. But 44MB/sec is what people consider 'possible'. I've gotten to 41MB/sec with g_mas_storage gadget. > almost never CPU bound. > > No need to optimize for speed this agressively. > > Signed-off-by: Denys Vlasenko > CC: Felipe Balbi > CC: linux-usb@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/usb/gadget/udc/r8a66597-udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/u= dc/r8a66597-udc.c > index baa0609..1d79a47 100644 > --- a/drivers/usb/gadget/udc/r8a66597-udc.c > +++ b/drivers/usb/gadget/udc/r8a66597-udc.c > @@ -296,7 +296,7 @@ static void r8a66597_change_curpipe(struct r8a66597 *= r8a66597, u16 pipenum, > } while ((tmp & mask) !=3D loop); > } >=20=20 > -static inline void pipe_change(struct r8a66597 *r8a66597, u16 pipenum) > +static void pipe_change(struct r8a66597 *r8a66597, u16 pipenum) > { > struct r8a66597_ep *ep =3D r8a66597->pipenum2ep[pipenum]; >=20=20 > --=20 > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXCzRLAAoJEIaOsuA1yqREZmkP/inv9Rg6Gvnmq1UuJoIYWSTZ Y+2fCCoWOyIWon+Q/ENy0eh+m8S21tVh1FpDgSJZoWzWNEl8Ec8jGBjLGhZLnsXB tMIzbKVDFy0qQokaWJEqyKMYlCb0d9IbL1cePYRLR2xadxE13cQwVH1q47x5nXxW 291WrIONl6O619QUa4K/n7AuTegA657w4oG+H0XlOZIDq54Z0vtCnz4pXvWLZxVv sYlfogpC3H8cHEExREKrbsEQ7nDnrg3f6ypkUsQG0Jq/bIErUUvPLPFuTcJaAYXB wtKipapWwdRPZcO7VQ/8zXy8SRuTvNaCQAlf5//NrXNYbrSxLEJpS9n851x9tdMe qKNvlOjMk2qh+65GsRKS+Wzh3GISYITE1pbQB9F/S+mNamRbzBA+mvTNSi1ljZni qar4ECo6nNpmOMZXm3dd5OeecdmW4AEPG3I3LyiL0BeJBKNHhiE9SiwuOyoyZDGz 3rd3KZj+9U6DDn1yRrLS6glqmaFHends2LqW8LFJi2NC/5lin30Zshqk6WFaEpY1 6aRoz7/0z84/Ihx8f7x9i7aAk2JkV3rWnGPtCvSkwqxmxGTnDcQYI0IkJOHyFjl2 Gn4dfgae3Dkd5CmAOXV7nLaO3l79wv97Z59MsyPrPyEdYKHUOm9j3h4EciIK4gHc 2idIPVurM2SoFHBOhBpi =3Ybr -----END PGP SIGNATURE----- --=-=-=--