Date: Mon, 11 Apr 2016 09:10:10 +0200
From: John Einar Reitan <john.reitan@foss.arm.com>
To: Colin Cross <ccross@google.com>
Cc: Laura Abbott <labbott@redhat.com>, Greg KH <gregkh@linuxfoundation.org>,
        Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= <arve@android.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ion: scatterlist offset not used for buffer map
Message-ID: <20160411071010.GA25871@e106921-lin.trondheim.arm.com>
Mail-Followup-To: Colin Cross <ccross@google.com>,
	Laura Abbott <labbott@redhat.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= <arve@android.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	lkml <linux-kernel@vger.kernel.org>
References: <1460028599-22356-1-git-send-email-john.reitan@foss.arm.com>
 <5706B70E.4040004@redhat.com>
 <20160408065626.GA25580@e106921-lin.trondheim.arm.com>
 <CAMbhsRTOpdjG8yShpFUvC3=aswLbFY8p7Q2Cab7pBh+2smY=+Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAMbhsRTOpdjG8yShpFUvC3=aswLbFY8p7Q2Cab7pBh+2smY=+Q@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 328
Lines: 6

> I don't think this is right.  A compound_page still has a page struct
> for every page, you should be passing the page struct where your data
> starts.  Using an offset > PAGE_SIZE is going to break lots of places,
> for example anywhere that uses kmap(sg_page(sg)).

Was kind-of expecting that response. Will update, thanks.