Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753178AbcDKIsX (ORCPT ); Mon, 11 Apr 2016 04:48:23 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54524 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbcDKIsW (ORCPT ); Mon, 11 Apr 2016 04:48:22 -0400 Subject: Re: [PATCH] can: mcp251x: Replace create_freezable_workqueue with alloc_workqueue To: Amitoj Kaur Chawla , wg@grandegger.com, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160408153210.GA15068@amitoj-Inspiron-3542> Cc: tj@kernel.org From: Marc Kleine-Budde Message-ID: <570B61DB.9070909@pengutronix.de> Date: Mon, 11 Apr 2016 10:35:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160408153210.GA15068@amitoj-Inspiron-3542> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TOhk9DpAvsb1W32dF343tIhEb1tpffRfC" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2462 Lines: 66 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TOhk9DpAvsb1W32dF343tIhEb1tpffRfC Content-Type: multipart/mixed; boundary="sQrJ3C3pfEgiGmfwRoPSRAiXxADgGwVB6" From: Marc Kleine-Budde To: Amitoj Kaur Chawla , wg@grandegger.com, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: tj@kernel.org Message-ID: <570B61DB.9070909@pengutronix.de> Subject: Re: [PATCH] can: mcp251x: Replace create_freezable_workqueue with alloc_workqueue References: <20160408153210.GA15068@amitoj-Inspiron-3542> In-Reply-To: <20160408153210.GA15068@amitoj-Inspiron-3542> --sQrJ3C3pfEgiGmfwRoPSRAiXxADgGwVB6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/08/2016 05:32 PM, Amitoj Kaur Chawla wrote: > Replace scheduled to be removed create_freezable_workqueue with > alloc_workqueue. >=20 > priv->wq should be explicitly set as freezable to ensure it is frozen > in the suspend sequence and work items are drained so that no new work > item starts execution until thawed. Thus, use of WQ_FREEZABLE flag > here is required. >=20 > WQ_MEM_RECLAIM flag has been set here to ensure forward progress > regardless of memory pressure. >=20 > The order of execution is not important so set @max_active as 0. >=20 > Signed-off-by: Amitoj Kaur Chawla > Acked-by: Tejun Heo Applied to can-next/master. Tnx, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --sQrJ3C3pfEgiGmfwRoPSRAiXxADgGwVB6-- --TOhk9DpAvsb1W32dF343tIhEb1tpffRfC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJXC2HbAAoJED07qiWsqSVqTx4H/RZu1D52slftsplnUe+1SaNU Xwp1tHXszSt5MZy2x8ss1hPBUnHkbAKQUqLm/jLx9ZEqHl8BmLkRVvH2LDd0/Ysv +R1GSyKecHdd8dk4VpOoxZB7bhKz6y54HPzLyaEPzRXGjwawoqg+3XiY/lC5lIJ5 BsPhaoYZPAijdxXXVJ3+doniroVwe0EnrDJ/UzvQG3af2ZdUN71aq0IfW2QR8yn0 rbLsj0YwcG+kU6U+wnRR4jF8Zk84cs1UYh8mT4WKXNm3WHLPdgGbrSZPVhj2Z44k GLGekznYbp8focxG1CoP3CWzWZIMH2ESTBskR6k2jI+kgZzbwFqwEvOI/lNoprQ= =Wc+h -----END PGP SIGNATURE----- --TOhk9DpAvsb1W32dF343tIhEb1tpffRfC--