Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130AbcDKKc1 (ORCPT ); Mon, 11 Apr 2016 06:32:27 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33194 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752336AbcDKKc0 (ORCPT ); Mon, 11 Apr 2016 06:32:26 -0400 Date: Mon, 11 Apr 2016 13:32:23 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Andrea Arcangeli , Andres Lagar-Cavilla , Yang Shi , Ning Qu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 08/10] huge pagecache: extend mremap pmd rmap lockout to files Message-ID: <20160411103223.GB22996@node.shutemov.name> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 17 On Tue, Apr 05, 2016 at 01:52:48PM -0700, Hugh Dickins wrote: > Whatever huge pagecache implementation we go with, file rmap locking > must be added to anon rmap locking, when mremap's move_page_tables() > finds a pmd_trans_huge pmd entry: a simple change, let's do it now. > > Factor out take_rmap_locks() and drop_rmap_locks() to handle the > locking for make move_ptes() and move_page_tables(), and delete > the VM_BUG_ON_VMA which rejected vm_file and required anon_vma. > > Signed-off-by: Hugh Dickins Yeah, it's cleaner than my variant. Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov