Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511AbcDKLFy (ORCPT ); Mon, 11 Apr 2016 07:05:54 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34013 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753148AbcDKLFt (ORCPT ); Mon, 11 Apr 2016 07:05:49 -0400 Date: Mon, 11 Apr 2016 14:05:45 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Andrea Arcangeli , Andres Lagar-Cavilla , Yang Shi , Ning Qu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/31] huge tmpfs: prepare counts in meminfo, vmstat and SysRq-m Message-ID: <20160411110545.GD22996@node.shutemov.name> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 31 On Tue, Apr 05, 2016 at 02:12:26PM -0700, Hugh Dickins wrote: > ShmemFreeHoles will show the wastage from using huge pages for small, or > sparsely occupied, or unrounded files: wastage not included in Shmem or > MemFree, but will be freed under memory pressure. (But no count for the > partially occupied portions of huge pages: seems less important, but > could be added.) And here first difference in interfaces comes: I don't have an equivalent in my implementation, as I don't track such information. It looks like an implementation detail for team-pages based huge tmpfs. We don't track anything similar for anon-THP. > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3830,6 +3830,11 @@ out: > } > > #define K(x) ((x) << (PAGE_SHIFT-10)) > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +#define THPAGE_PMD_NR HPAGE_PMD_NR > +#else > +#define THPAGE_PMD_NR 0 /* Avoid BUILD_BUG() */ > +#endif I've just put THP-related counters on separate line and wrap it into #ifdef. -- Kirill A. Shutemov