Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754836AbcDKMkw (ORCPT ); Mon, 11 Apr 2016 08:40:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33264 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754585AbcDKMku (ORCPT ); Mon, 11 Apr 2016 08:40:50 -0400 From: Kalle Valo To: Larry Finger Cc: Eric Dumazet , "David S. Miller" , linux-next , linux-netdev@vger.kernel.org, LKML , linux-wireless Subject: Re: Kernel crash on startup - bisected to commit 3b24d854cb35 References: <570892F9.9030700@lwfinger.net> <570934C9.5020008@lwfinger.net> Date: Mon, 11 Apr 2016 15:40:38 +0300 In-Reply-To: <570934C9.5020008@lwfinger.net> (Larry Finger's message of "Sat, 9 Apr 2016 11:58:49 -0500") Message-ID: <87inzoz5bt.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 38 Larry Finger writes: >> Can you double check you have this fix ? >> >> commit 8501786929de4616b10b8059ad97abd304a7dddf >> Author: Eric Dumazet >> Date: Wed Apr 6 22:07:34 2016 -0700 >> >> tcp/dccp: fix inet_reuseport_add_sock() >> >> David Ahern reported panics in __inet_hash() caused by my recent commit. >> >> The reason is inet_reuseport_add_sock() was still using >> sk_nulls_for_each_rcu() instead of sk_for_each_rcu(). >> SO_REUSEPORT enabled listeners were causing an instant crash. >> >> While chasing this bug, I found that I forgot to clear SOCK_RCU_FREE >> flag, as it is inherited from the parent at clone time. >> >> Fixes: 3b24d854cb35 ("tcp/dccp: do not touch listener sk_refcnt >> under synflood") >> Signed-off-by: Eric Dumazet >> Reported-by: David Ahern >> Tested-by: David Ahern >> Signed-off-by: David S. Miller > > No, I did not have that patch. After pulling from net-next to get it, > my system no longer panics. > > Note to linux-wireless readers. At the moment, a system built from > wireless-drivers-next will have this problem. I'm currently writing a pull request to Dave and once he pulls it I'll fast forward wireless-drivers-next to latest net-next. Usually this take two days or so. -- Kalle Valo