Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933604AbcDKNyR (ORCPT ); Mon, 11 Apr 2016 09:54:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:40320 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932779AbcDKNyM (ORCPT ); Mon, 11 Apr 2016 09:54:12 -0400 Date: Mon, 11 Apr 2016 15:54:05 +0200 Message-ID: From: Takashi Iwai To: William Breathitt Gray Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, gregkh@linuxfoundation.org, alsa-devel@alsa-project.org, linux-scsi@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 2/4] sound: isa: sscape: Use correct format identifier for size_t In-Reply-To: <903e7f51989907f3de2159efb99bd65bf3dc30f7.1460379702.git.vilhelm.gray@gmail.com> References: <903e7f51989907f3de2159efb99bd65bf3dc30f7.1460379702.git.vilhelm.gray@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 46 On Mon, 11 Apr 2016 15:25:52 +0200, William Breathitt Gray wrote: > > The 'size' member of a struct firmware is passed to snd_printk with a > respective format string using the %d identifier. The 'size' member is > of type size_t, but format identifier %d indicates a signed int data > type. This patch replaces the %d format identifier with the correct %zu > format identifier for size_t data types. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Signed-off-by: William Breathitt Gray This is basically irrelevant from ISA issue you're trying to solve, so I'm going to apply this one individually to my tree. thanks, Takashi > --- > sound/isa/sscape.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c > index 7b248cd..fdcfa29 100644 > --- a/sound/isa/sscape.c > +++ b/sound/isa/sscape.c > @@ -591,7 +591,7 @@ static int sscape_upload_microcode(struct snd_card *card, int version) > } > err = upload_dma_data(sscape, init_fw->data, init_fw->size); > if (err == 0) > - snd_printk(KERN_INFO "sscape: MIDI firmware loaded %d KBs\n", > + snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n", > init_fw->size >> 10); > > release_firmware(init_fw); > -- > 2.7.3 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >