Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755370AbcDKODI (ORCPT ); Mon, 11 Apr 2016 10:03:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60272 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754930AbcDKODG (ORCPT ); Mon, 11 Apr 2016 10:03:06 -0400 Date: Mon, 11 Apr 2016 15:03:00 +0100 From: Mark Brown To: Thierry Reding Cc: Jon Hunter , Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20160411140300.GH3351@sirena.org.uk> References: <1460038959-21592-1-git-send-email-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cfJ13FhsvNR/yOpm" Content-Disposition: inline In-Reply-To: <1460038959-21592-1-git-send-email-thierry.reding@gmail.com> X-Cookie: I invented skydiving in 1989! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/5] regulator: core: Resolve supply earlier X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 35 --cfJ13FhsvNR/yOpm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 07, 2016 at 04:22:35PM +0200, Thierry Reding wrote: > + /* > + * set_machine_constraints() needs the supply to be resolved in order > + * to support querying the current voltage in bypass mode. Resolve it > + * here to more easily handle deferred probing. > + */ > + ret = regulator_resolve_supply(rdev); > + if (ret < 0) > + goto scrub; This shouldn't be a hard dependency: most regulators won't be in bypass mode or otherwise depend on their parents enough to need this. --cfJ13FhsvNR/yOpm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXC66TAAoJECTWi3JdVIfQZlUH/R0WvlfmumyopEktYDStAD3q WEfZQQ2wILF8hv0QN6hpem5fqHmdNTOqKiqiAXctLAVD0W/nr/TPHupgIB2ZAZjg EW3zoSLnDMJWwEPxoJiW8fOCjb1+psCVn4E00vQ6QEO9LkEMcjTQTa0+HLn1NeZq f9+MHWXBX/8DshavuKTCDeLtTvvM62sejLNFbUcUiRYGOB7XxWf9YdyJ3595Tsnu juBi7n57v6C/DJpVn7w4nNXFz1usBxNcPgrVQrTuwU8uVbKuf+z8dPi9cmgrvqMd 1L+XbOYbc4kWAejlQnmwHt8W3CgvIt2efejMsWYQh0uOUsgynPmHrdXJkqL8+9M= =CeeG -----END PGP SIGNATURE----- --cfJ13FhsvNR/yOpm--