Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755078AbcDKOQX (ORCPT ); Mon, 11 Apr 2016 10:16:23 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37131 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476AbcDKOQV (ORCPT ); Mon, 11 Apr 2016 10:16:21 -0400 Subject: Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for detecting reliable stack traces To: Josh Poimboeuf , Miroslav Benes References: <1f8c648ed8b8eb49a75f5a6cacf8b7ca76f44fa9.1458933243.git.jpoimboe@redhat.com> <20160404175437.gjj2ghphzv5foh4j@treble.redhat.com> Cc: Jiri Kosina , Jessica Yu , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Vojtech Pavlik From: Jiri Slaby Message-ID: <570BB1AE.6090502@suse.cz> Date: Mon, 11 Apr 2016 16:16:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160404175437.gjj2ghphzv5foh4j@treble.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TCUmAtHnsKiio9xEa2toiKpe78Kx3tCXr" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3521 Lines: 87 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TCUmAtHnsKiio9xEa2toiKpe78Kx3tCXr Content-Type: multipart/mixed; boundary="OfsalONHhtu6bc1jibV7psQKCUHhlbDSX" From: Jiri Slaby To: Josh Poimboeuf , Miroslav Benes Cc: Jiri Kosina , Jessica Yu , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Vojtech Pavlik Message-ID: <570BB1AE.6090502@suse.cz> Subject: Re: [RFC PATCH v1.9 07/14] x86/stacktrace: add function for detecting reliable stack traces References: <1f8c648ed8b8eb49a75f5a6cacf8b7ca76f44fa9.1458933243.git.jpoimboe@redhat.com> <20160404175437.gjj2ghphzv5foh4j@treble.redhat.com> In-Reply-To: <20160404175437.gjj2ghphzv5foh4j@treble.redhat.com> --OfsalONHhtu6bc1jibV7psQKCUHhlbDSX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/04/2016, 07:54 PM, Josh Poimboeuf wrote: > On Thu, Mar 31, 2016 at 03:03:16PM +0200, Miroslav Benes wrote: >> On Fri, 25 Mar 2016, Josh Poimboeuf wrote: >> >>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >>> index 2dc18605..76274b8 100644 >>> --- a/arch/x86/Kconfig >>> +++ b/arch/x86/Kconfig >>> @@ -138,6 +138,7 @@ config X86 >>> select HAVE_PERF_REGS >>> select HAVE_PERF_USER_STACK_DUMP >>> select HAVE_REGS_AND_STACK_ACCESS_API >>> + select HAVE_RELIABLE_STACKTRACE if X86_64 && FRAME_POINTER >> >> I understand we have to rely on frame pointer for now. Do you plan to = >> switch to dwarf unwinder one day in the future? IOW is there a plan to= =20 >> implement dwarf stuff generation in objtool and then to have a dwarf-b= ased=20 >> stack unwinder upstream and to use it for live patching?=20 >=20 > Yes, adding DWARF validation and generation to objtool and creating a > DWARF unwinder upstream are all planned, hopefully soon. I may seem to be obtrusive, but here, I would like to offer my help again. If you need any kind of help with the unwinder, I can definitely help with that. Be it coding, testing, ideas discussion or anything else.= We had been using unwinder for over a decade in SUSE but it stopped working for assembly recently (for obvious reasons). So having a working and reliable unwinder again is one of the top priorities for us. thanks, --=20 js suse labs --OfsalONHhtu6bc1jibV7psQKCUHhlbDSX-- --TCUmAtHnsKiio9xEa2toiKpe78Kx3tCXr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXC7GuAAoJEL0lsQQGtHBJhCIP/jru+vIcGaURTz4b314vEPV+ lVDYGY5519LN9jijalNRrWtHTrDbRv3rGp1FRD2oAhyTt+Wk75FbkcaKSvfEvxyc b3g8F3K6e/3er34oxRiaojeJ5NS9RKm6qb+XXlc0N26OEwVagV64VSG4WbLZ6Now R9nkNZ3VKEsyqYFGiVoQiWeiNG9ZEIYyCXRDj2zEkE10mv+xcnfCuJoUssQJzXL4 vJ9ov7u8czw3Nm25iFd/gVokbcNaGbbH9gziTVJ6OU24DUXqE6aZB+wznGoIKlBy rvrpfMQ4IAS3fXg7OFc/D1nLHvd092fQy5UHuQ034f0+MKCGIwYrJRl9uSJL3/ZV 0bRJJzencpzbX+3inBXKWpj8qKJbTcYzJAcMsTqShUGfLRpig3xsGKoR4hCRGofz f2NYuj2NZC0IseLjLMGu0+xzIXlLhj1KaabOMHc3dD4uK3e+eRWQV6AuGxP1zMQY emHA6/KhfpMTqGAkZwgPqHo1E3NE+ur/wOzHBTbztBN4xdFC3A+9DSz9apPz+yrG YTTP2TSSmQNzApvE29kBMDOA7xlcFIydfeG8R/+ltlGpebL/pEFh7sCfKn9/Thlt og8TtkQpwKBzPZeWxwrs5zOWNSdpHXRHpgZr6j4WRJQyfDiyaePlwQa8B6LA+mym J95sigUeo8H5c6M7SSBT =10VF -----END PGP SIGNATURE----- --TCUmAtHnsKiio9xEa2toiKpe78Kx3tCXr--