Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932459AbcDKOWm (ORCPT ); Mon, 11 Apr 2016 10:22:42 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:36012 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932298AbcDKOWk (ORCPT ); Mon, 11 Apr 2016 10:22:40 -0400 Message-ID: <1460384551.6473.551.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH net v2] net: sched: do not requeue a NULL skb From: Eric Dumazet To: Lars Persson Cc: Lars Persson , netdev@vger.kernel.org, jhs@mojatatu.com, linux-kernel@vger.kernel.org, xiyou.wangcong@gmail.com Date: Mon, 11 Apr 2016 07:22:31 -0700 In-Reply-To: <570BA8C7.1000905@axis.com> References: <1460355869-13539-1-git-send-email-larper@axis.com> <1460380981.6473.544.camel@edumazet-glaptop3.roam.corp.google.com> <570BA8C7.1000905@axis.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 378 Lines: 13 On Mon, 2016-04-11 at 15:38 +0200, Lars Persson wrote: > I though it would be prudent because the queue can be non-empty even for > the case of skb=NULL. So should it be there in this patch, another patch > or not at all ? Then maybe change return code ? It seems strange that a validate_xmit_skb_list() failure stops the __qdisc_run() loop but schedules another round.