Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755247AbcDKOXr (ORCPT ); Mon, 11 Apr 2016 10:23:47 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:49300 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbcDKOXp convert rfc822-to-8bit (ORCPT ); Mon, 11 Apr 2016 10:23:45 -0400 From: Vineet Gupta To: Michal Hocko , "linux-mm@kvack.org" CC: Andrew Morton , LKML , Michal Hocko , "linux-arch@vger.kernel.org" Subject: Re: [PATCH 06/19] arc: get rid of superfluous __GFP_REPEAT Thread-Topic: [PATCH 06/19] arc: get rid of superfluous __GFP_REPEAT Thread-Index: AQHRk+J8Lovnz43+SEWnDmWlx/yaqw== Date: Mon, 11 Apr 2016 14:23:42 +0000 Message-ID: References: <1460372892-8157-1-git-send-email-mhocko@kernel.org> <1460372892-8157-7-git-send-email-mhocko@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 724 Lines: 21 On Monday 11 April 2016 04:38 PM, Michal Hocko wrote: > From: Michal Hocko > > __GFP_REPEAT has a rather weak semantic but since it has been introduced > around 2.6.12 it has been ignored for low order allocations. > > pte_alloc_one_kernel uses __get_order_pte but this is obviously > always zero because BITS_FOR_PTE is not larger than 9 yet the page > size is always larger than 4K. This means that this flag has never > been actually useful here because it has always been used only for > PAGE_ALLOC_COSTLY requests. > > Cc: Vineet Gupta > Cc: linux-arch@vger.kernel.org > Signed-off-by: Michal Hocko Acked-by: Vineet Gupta Thx, -Vineet