Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755346AbcDKOcw (ORCPT ); Mon, 11 Apr 2016 10:32:52 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60370 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754092AbcDKOcu (ORCPT ); Mon, 11 Apr 2016 10:32:50 -0400 Date: Mon, 11 Apr 2016 15:32:39 +0100 From: Mark Brown To: Thierry Reding Cc: Javier Martinez Canillas , Jon Hunter , Liam Girdwood , linux-kernel@vger.kernel.org, Bjorn Andersson Message-ID: <20160411143239.GJ3351@sirena.org.uk> References: <1460038959-21592-1-git-send-email-thierry.reding@gmail.com> <570B8376.6030505@nvidia.com> <20160411114612.GD17743@ulmo.ba.sec> <20160411125814.GE3351@sirena.org.uk> <20160411130914.GA16994@ulmo.ba.sec> <570BAA68.2000701@osg.samsung.com> <20160411135715.GG3351@sirena.org.uk> <20160411140730.GA27400@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="huG+SbfbdD6eblZQ" Content-Disposition: inline In-Reply-To: <20160411140730.GA27400@ulmo.ba.sec> X-Cookie: I invented skydiving in 1989! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/5] regulator: core: Resolve supply earlier X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1859 Lines: 45 --huG+SbfbdD6eblZQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2016 at 04:07:30PM +0200, Thierry Reding wrote: > Okay, so how do we proceed here? Currently Jetson TK1 is broken because > bypass mode requires the parent to be available at probe time due to new > code that's now doing a regulator_get_voltage() during the initial call > to set_machine_constraints(). I think we should be doing what I'd expected this series to do and looking up the supply as and when we need it when applying constraints. =20 That will only affect systems where there is a practical issue which should minimise the impact. Long term we want a bigger refactoring but I think we need to sort out what's going on with probe ordering in general before we do that, that's part of the problem here - people really aren't happy with deferral and for good reason. > Perhaps to unbreak boards the original commit that caused this failure > fa93fd4ecc9c ("regulator: core: Ensure we are at least in bounds for our > constraints") should be reverted for now? That breaks other boards that start up with out of spec variable voltage regulators and therefore fail to probe some of the devices using those regulators. --huG+SbfbdD6eblZQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXC7WGAAoJECTWi3JdVIfQmJ8H/jCuY28tWpWPl8oAbbBkWmZh Ay3eg7J5a4m2NAkge68SL6NRynCrCYEZcsxCPVdlEc/4Hr+2EJxSE8i3amiDrMZo gwKQcHR74g4pLHgXO6rzKkFF/+6/lcuZVC7m93K6Vi18VvSWsLpCwvWtJLtE+8zD IY7ShDweITA4O7UHAdxzQYHygsiLcDtL6qAPeaJjFzCw95HMgOFxaPqM9CUpAaQJ X63mHwZWlg1hPi/LwOzXrzsKu6dygQ2UKFbCSo8e5HxuOGNsRtGAEI8dVPLSffdD nk1OGycpQHnM25j9bCF9qh+85IDUuipBaiubyQadmH6UWgITEVfJ0EZ11cGXB/s= =Re9z -----END PGP SIGNATURE----- --huG+SbfbdD6eblZQ--