Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbcDKOnR (ORCPT ); Mon, 11 Apr 2016 10:43:17 -0400 Received: from foss.arm.com ([217.140.101.70]:50145 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753641AbcDKOnP (ORCPT ); Mon, 11 Apr 2016 10:43:15 -0400 Subject: Re: [PATCH v8 3/3] irqchip: add nps Internal and external irqchips To: Vineet Gupta , Noam Camus References: <1459707299-31564-1-git-send-email-noamca@mellanox.com> <1459707299-31564-4-git-send-email-noamca@mellanox.com> <570B9E46.7050402@arm.com> <570BA01F.2060100@arm.com> <570BA277.5090202@arm.com> Cc: arcml , lkml , Jason Cooper , Thomas Gleixner , Daniel Lezcano From: Marc Zyngier X-Enigmail-Draft-Status: N1110 Organization: ARM Ltd Message-ID: <570BB7FF.2070306@arm.com> Date: Mon, 11 Apr 2016 15:43:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1524 Lines: 39 Hi Vineet, On 11/04/16 15:09, Vineet Gupta wrote: > On Monday 11 April 2016 06:41 PM, Marc Zyngier wrote: >>>>> It doesn't mean I really approve of it. The default domain thing is >>>>> going to end-up biting you in the rear. But hey, better having this >>>>> supported upstream than leaving these patches up in the air... > > Hi Marc, > > Aside of this - there's been serious rework of ARC intc / timers code spurred by > some of your comments for this irqchip driver. > > - We now probe timers via DT (so timer irq comes off of DT as well) > - We have now switched to linear irq domain (vs. legacy) > > IMHO a bunch of ugliness / non-desirability remains (there's likely more) > - calling irq_set_default_host() > - calling irq_create_mapping with NULL for IPIs > > I really want to do things in better way - make it more modern ... hence would > request you to please take a look at my latest series (I can post the patches here > if that helps - although it felt I was spamming you and you got pissed off or > something and were not responding of late :-) No, it is just that my bandwidth has been max'd out over the past few months. There is only so many patches I can look at while still being able to write some code myself, and I may have flagged your emails as "things to look at when I have time", which may not have happened in a timely manner - sorry about that. Just keep me on CC when you repost them, and I'll try to be a bit more reactive. Thanks, M. -- Jazz is not dead. It just smells funny...