Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753441AbcDKOs1 (ORCPT ); Mon, 11 Apr 2016 10:48:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:44319 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbcDKOs0 (ORCPT ); Mon, 11 Apr 2016 10:48:26 -0400 Date: Mon, 11 Apr 2016 16:48:24 +0200 Message-ID: From: Takashi Iwai To: Sven Eckelmann Cc: alsa-devel@alsa-project.org, Simon Wunderlich , Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ALSA: hda/realtek - Enable the ALC292 dock fixup on the Thinkpad T460s In-Reply-To: <1639739.FqnMfNtjzc@bentobox> References: <1460366498-14101-1-git-send-email-sven@narfation.org> <1639739.FqnMfNtjzc@bentobox> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2198 Lines: 68 On Mon, 11 Apr 2016 16:43:38 +0200, Sven Eckelmann wrote: > > On Monday 11 April 2016 16:05:49 Takashi Iwai wrote: > > On Mon, 11 Apr 2016 11:21:38 +0200, > > Sven Eckelmann wrote: > > > > > > The Lenovo Thinkpad T460s requires the alc_fixup_tpt440_dock as well in > > > order to get working sound output on the docking stations headphone jack. > > > > > > Patch tested on a Thinkpad T460s (20F9CT01WW) using a ThinkPad Ultradock > > > on kernel 4.4.6. > > > > > > Signed-off-by: Sven Eckelmann > > > Tested-by: Simon Wunderlich > > > --- > > > v2: > > > - rebased on current master > > > > > > sound/pci/hda/patch_realtek.c | 18 +++++++++++++++++- > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > > index fefe83f..36d371c 100644 > > > --- a/sound/pci/hda/patch_realtek.c > > > +++ b/sound/pci/hda/patch_realtek.c > > > @@ -4760,6 +4760,8 @@ enum { > > > ALC225_FIXUP_DELL1_MIC_NO_PRESENCE, > > > ALC280_FIXUP_HP_HEADSET_MIC, > > > ALC221_FIXUP_HP_FRONT_MIC, > > > + ALC292_FIXUP_TPT460_DOCK, > > > + ALC292_FIXUP_TPT460, > > > }; > > > > > > static const struct hda_fixup alc269_fixups[] = { > > > @@ -5409,6 +5411,18 @@ static const struct hda_fixup alc269_fixups[] = { > > > { } > > > }, > > > }, > > > + [ALC292_FIXUP_TPT460_DOCK] = { > > > + .type = HDA_FIXUP_FUNC, > > > + .v.func = alc_fixup_tpt440_dock, > > > + .chained = true, > > > + .chain_id = ALC269_FIXUP_THINKPAD_ACPI > > > + }, > > > + [ALC292_FIXUP_TPT460] = { > > > + .type = HDA_FIXUP_FUNC, > > > + .v.func = alc_fixup_disable_aamix, > > > + .chained = true, > > > + .chain_id = ALC292_FIXUP_TPT460_DOCK, > > > + }, > > > > We don't need to add two entries but just one, something like below. > > > > [ALC292_FIXUP_TPT460] = { > > .type = HDA_FIXUP_FUNC, > > .v.func = alc_fixup_tpt440_dock, > > .chained = true, > > .chain_id = ALC293_FIXUP_LENOVO_SPK_NOISE, > > }, > > Just wanted to keep it consistent with the TPT440 entries. Oh, you don't have to inherit the messes from there :) I'd rather like to keep the list shorter. Takashi