Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbcDKOtJ (ORCPT ); Mon, 11 Apr 2016 10:49:09 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36190 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcDKOtH (ORCPT ); Mon, 11 Apr 2016 10:49:07 -0400 Date: Mon, 11 Apr 2016 16:49:02 +0200 From: Thierry Reding To: Mark Brown Cc: Javier Martinez Canillas , Jon Hunter , Liam Girdwood , linux-kernel@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH 1/5] regulator: core: Resolve supply earlier Message-ID: <20160411144902.GC27400@ulmo.ba.sec> References: <1460038959-21592-1-git-send-email-thierry.reding@gmail.com> <570B8376.6030505@nvidia.com> <20160411114612.GD17743@ulmo.ba.sec> <20160411125814.GE3351@sirena.org.uk> <20160411130914.GA16994@ulmo.ba.sec> <570BAA68.2000701@osg.samsung.com> <20160411135715.GG3351@sirena.org.uk> <20160411140730.GA27400@ulmo.ba.sec> <20160411143239.GJ3351@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jousvV0MzM2p6OtC" Content-Disposition: inline In-Reply-To: <20160411143239.GJ3351@sirena.org.uk> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2463 Lines: 59 --jousvV0MzM2p6OtC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2016 at 03:32:39PM +0100, Mark Brown wrote: > On Mon, Apr 11, 2016 at 04:07:30PM +0200, Thierry Reding wrote: >=20 > > Okay, so how do we proceed here? Currently Jetson TK1 is broken because > > bypass mode requires the parent to be available at probe time due to new > > code that's now doing a regulator_get_voltage() during the initial call > > to set_machine_constraints(). >=20 > I think we should be doing what I'd expected this series to do and > looking up the supply as and when we need it when applying constraints. = =20 > That will only affect systems where there is a practical issue which > should minimise the impact. I must have misinterpreted our discussion on IRC, then, because I thought this was exactly what you had been expecting. =3D\ I'll go look for my earlier patch and repost. > Long term we want a bigger refactoring but > I think we need to sort out what's going on with probe ordering in > general before we do that, that's part of the problem here - people > really aren't happy with deferral and for good reason. What happened to correctness first? I thought we had at some point all agreed that even if deferred probe wasn't perfect it would at least give us correct results. And if all the code in place to properly establish the dependencies we could rid ourselves of all the downsides at once if ever we came up with a better alternative. Thierry --jousvV0MzM2p6OtC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXC7lbAAoJEN0jrNd/PrOhNP8QAJkC5jl0sxPgPZMJ0TcM7TwS 998hfBIX2lSeoPm6NSJGpogp3kW8lyX+5u/r/g4QKRwnEVbiLIbjoWftJzsA6pRk 4n0KkqEEp11lM9iueP1lJ1AyH2c80SUV9RzI6tTfl3ChFPZvdvQlEA1uyk8t8/F+ sBTquFmPpFWgwy1NJ+rdGc7urzat/U46+RpQ4s+CG10ZPb0YDeeFH6py7dFaifS3 xuMbN5gwTaquDvf5DMRbe2ySutOJdGcqzkfz0J1ogbbDBO0eJ391Gl6YYIngdXPB m+DU2IZ+wp+fLUSz3bKJsqmFLGCBF2fRu+B3OQvCMNJMHWvygV0Ho0qpCagokwMm OkOpfIsZtDcm3aAGdNMx4V+ZY0231572xigBpnCIrd6p5hKpTwPIBooSs+5QZgHZ egPb757J8m17OWocnQGuCWz4yFl1uLalfLJ3OwoYVaRuONo1nFzTaKthZN+QvWzc kmBgY6/WJhpyGAc8iPxFxxe7GNKED9C9MYld9+D4AKiRJAPtqag1iPqLvb28uW44 b0Dv8kxa13hjRPbTHvmMi56BCGHPmEmo1rrC5TQhx14yTa5ENFNfpstshsm2mDsz U39AelKbhH/L39+abJJQZhdyLd1BbGOu3WZPWdc+9ukMppA86xfsa59tPUa4j20B zILztCvdzFgcrd171EPD =9dXD -----END PGP SIGNATURE----- --jousvV0MzM2p6OtC--