Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753069AbcDKOuF (ORCPT ); Mon, 11 Apr 2016 10:50:05 -0400 Received: from mail.kernel.org ([198.145.29.136]:52140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbcDKOuB (ORCPT ); Mon, 11 Apr 2016 10:50:01 -0400 Date: Mon, 11 Apr 2016 09:49:56 -0500 From: Rob Herring To: Robin van der Gracht Cc: linux-kernel@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Miguel Ojeda Sandonis , Thierry Reding , Jonathan Cameron , Mark Brown , Maxime Ripard , devicetree@vger.kernel.org Subject: Re: [PATCH v5 2/2] auxdisplay: ht16k33: Driver for LED controller Message-ID: <20160411144956.GA26808@rob-hp-laptop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 42 On Thu, Apr 07, 2016 at 10:54:01AM +0200, Robin van der Gracht wrote: > Added a driver for the Holtek HT16K33 LED controller with keyscan. > > Signed-off-by: Robin van der Gracht > --- > Changes in v5: > - Updated compatible string > - the HT16K33_FB_SIZE define now uses BYTES_PER_ROW as multiplier instead of 2 > - Dropped a trailing '\' in ht16k33.txt > - Shortened commit message (exceeded 80 chars in v4) > > .../devicetree/bindings/display/ht16k33.txt | 42 ++ > drivers/auxdisplay/Kconfig | 9 + > drivers/auxdisplay/Makefile | 1 + > drivers/auxdisplay/ht16k33.c | 563 +++++++++++++++++++++ > 4 files changed, 615 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt > create mode 100644 drivers/auxdisplay/ht16k33.c > > diff --git a/Documentation/devicetree/bindings/display/ht16k33.txt b/Documentation/devicetree/bindings/display/ht16k33.txt > new file mode 100644 > index 0000000..d9694b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ht16k33.txt > @@ -0,0 +1,42 @@ > +Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan > +------------------------------------------------------------------------------- > + > +Required properties: > +- compatible: "holtek,ht16k33" > +- reg: I2C slave address of the chip. > +- interrupt-parent: A phandle pointing to the interrupt controller > + serving the interrupt for this chip. > +- interrupts: Interrupt specification for the key pressed interrupt. > +- refresh-rate-hz: Display update interval in HZ. > +- debounce-delay-ms: Debouncing interval time in microseconds. '-ms' is milliseconds, but you have usec... ^^^^^^^^^^^^ Otherwise, Acked-by: Rob Herring